Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions/#2974): Add extension override for Ionide.Ionide-fsharp #3019

Merged
merged 3 commits into from
Jan 20, 2021

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Jan 20, 2021

Issue: The Ionide.Ionide-fsharp extension depends on ms-dotnettools.csharp, which isn't available on open-vsx

Fix: The best-case fix would be to have the ionide-fsharp extension published to open-vsx and have proper dependencies. In the meantime, add a temporary override to map ms-dotnettols.csharp -> muhammad-sammy.csharp to unblock the extension.

With this change - basic language features work:
2021-01-14 16 37 31

Fixes #2974
Related #1058

@bryphe bryphe changed the title fix(extensions/#2974): Add extension override fix(extensions/#2974): Add extension override for Ionide.Ionide-fsharp Jan 20, 2021
@bryphe bryphe added the N-screenshot Notes: Screenshot label Jan 20, 2021
@bryphe bryphe added this to the 0.5.4 milestone Jan 20, 2021
@bryphe bryphe merged commit 7929ea5 into master Jan 20, 2021
@bryphe bryphe deleted the fix/extension/2974/add-extension-override branch January 20, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
N-screenshot Notes: Screenshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension: Ionide-fsharp extension does not work
1 participant