Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AppRoute NameSpace and Fix Router Scopes #47

Closed
jonathan-casarrubias opened this issue May 19, 2018 · 0 comments
Closed

Implement AppRoute NameSpace and Fix Router Scopes #47

jonathan-casarrubias opened this issue May 19, 2018 · 0 comments
Assignees
@jonathan-casarrubias
Labels
1.0.0-beta.1 bug Something isn't working
Milestone
1.0.0-beta

Comments

@jonathan-casarrubias
Copy link
Member

Some routes are broken because of scope problems, extract app routes from app factory and fix scopes on each route
@jonathan-casarrubias jonathan-casarrubias added bug Something isn't working 1.0.0-beta.1 labels May 19, 2018
@jonathan-casarrubias jonathan-casarrubias added this to the 1.0.0-beta.1 milestone May 19, 2018
@jonathan-casarrubias jonathan-casarrubias self-assigned this May 19, 2018
jonathan-casarrubias pushed a commit that referenced this issue May 19, 2018
Release 1.0.0-beta.1 🚀
8ae08a6 
GitHub Milestone: https://github.com/onixjs/core/milestone/2?closed=1

- Fix: #43
- Fix: #42
- Fix: #41
- Fix: #47
jonathan-casarrubias pushed a commit that referenced this issue May 21, 2018
Release 1.0.0-beta.1 🚀
df34762 
GitHub Milestone: https://github.com/onixjs/core/milestone/2?closed=1

- Fix: #43
- Fix: #42
- Fix: #41
- Fix: #47
- Fix: #48
jonathan-casarrubias pushed a commit that referenced this issue May 21, 2018
Release 1.0.0-beta.1 🚀
6c6f42d 
GitHub Milestone: https://github.com/onixjs/core/milestone/2?closed=1

- Fix: #43
- Fix: #42
- Fix: #41
- Fix: #47
- Fix: #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathan-casarrubias jonathan-casarrubias

Labels
1.0.0-beta.1 bug Something isn't working
Projects
None yet
Milestone
1.0.0-beta
Development

No branches or pull requests
1 participant
@jonathan-casarrubias