Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always define start and stop on Service #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 22, 2024

  1. Always define start and stop on Service

    `Service`'s types say that `start` and `stop` can be undefined. This is
    impossible in practice because the only way to instantiate a `Service`
    is via `Registry.prototype.publish`, which always sets these properties.
    
    This small refactor avoids this problem to ensure that `start` and
    `stop` are always defined, which should make the library a bit easier to
    use.
    EvanHahn committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8689343 View commit details
    Browse the repository at this point in the history