Skip to content

Optimize Transpose->Slice regardless of Slice's axes #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2021
Merged

Optimize Transpose->Slice regardless of Slice's axes #1330

merged 4 commits into from
Feb 10, 2021

Conversation

mateusztabaka
Copy link
Contributor

@mateusztabaka mateusztabaka commented Feb 9, 2021 •
edited
Loading

Signed-off-by: Mateusz Tabaka mateusz.tabaka@intel.com

@mateusztabaka mateusztabaka force-pushed the slicetranspose branch 2 times, most recently from 079a522 to 7277393 Compare February 9, 2021 23:23
@mateusztabaka mateusztabaka changed the title Optimize Transpose->Slice->Transpose to a single Slice regardless of … Optimize Transpose->Slice regardless of Slice's axes Feb 9, 2021
@mateusztabaka
Optimize Transpose->Slice regardless of Slice's axes
b91d3e8 
Signed-off-by: Mateusz Tabaka <mateusz.tabaka@intel.com>
@TomWildenhain-Microsoft
Copy link
Collaborator

Feel free to request a review from me when you are ready to have this merged.

@mateusztabaka
Copy link
Contributor Author

I'm ready, so I'd appreciate your comments on this (seems like I can't add reviewers from github GUI, so I guess I can mark my readiness in the comments section).

TomWildenhain-Microsoft
TomWildenhain-Microsoft suggested changes Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@TomWildenhain-Microsoft TomWildenhain-Microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some small changes with the tests. Now that it's reviewed, please submit updates to a new commit instead of amending this one.

@mateusztabaka
Rename test_transpose_slice_10 test case to test_transpose_slice_opse…
b616452 
…t_10

Signed-off-by: Mateusz Tabaka <mateusz.tabaka@intel.com>
@mateusztabaka
Parameterize axes for test_transpose_slice
14ecc00 
Signed-off-by: Mateusz Tabaka <mateusz.tabaka@intel.com>
@TomWildenhain-Microsoft TomWildenhain-Microsoft merged commit 37d0c28 into onnx:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TomWildenhain-Microsoft TomWildenhain-Microsoft TomWildenhain-Microsoft approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusztabaka @TomWildenhain-Microsoft