fix some bugs #398
Merged
fix some bugs #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucienwang1009
commented
Mar 21, 2019
lucienwang1009
commented
- correct input dtype when run pretrained model.
- support more dtype for Maximum and Minimum and add unittests.
- any empty input of concat op will lead to seg fault on onnxruntime. here I workaround it by remove concat op when its input is empty.
- fix bugs when parsing tensor value of const op.
nbcsm
requested changes
Mar 21, 2019
pengwa
reviewed
Mar 22, 2019
lucienwang1009
force-pushed
the
pr_for_new_model
branch
3 times, most recently
from
844348f to
c4817cf
Compare
nbcsm
requested changes
Mar 22, 2019
pengwa
reviewed
Mar 22, 2019
lucienwang1009
force-pushed
the
pr_for_new_model
branch
from
c4817cf to
20f081b
Compare
|
@lucienwang1009 , please add a few tests to cover these special cases in |
nbcsm
approved these changes
Mar 25, 2019
|
@lucienwang1009, and also a test to cover concat input removal case. |
pengwa
approved these changes
Mar 25, 2019
nbcsm
requested changes
Mar 25, 2019
lucienwang1009
force-pushed
the
pr_for_new_model
branch
from
80f7857 to
da5a034
Compare
nbcsm
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.