Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modelregistry: fix bug in ExtractPaths #1205

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Modelregistry: fix bug in ExtractPaths #1205

merged 2 commits into from
Sep 11, 2020

Conversation

SeanCondon
Copy link
Contributor

Also removed a duplicate function

Convert enum (from identityref) as numbers in to strings

@SeanCondon
Modelregistry: fix bug in ExtractPaths
1e8449f 
Also removed a duplicate function
@SeanCondon SeanCondon added the bug 🪲 Something isn't working label Sep 11, 2020
@SeanCondon SeanCondon added this to the Aether 2020Q3 milestone Sep 11, 2020
@SeanCondon SeanCondon self-assigned this Sep 11, 2020
@adibrastegarnia
Copy link
Contributor

@SeanCondon
Perhaps you should run all the integration tests locally (if you haven't done already) a few times and make sure they pass.

@SeanCondon
Copy link
Contributor Author

I will now - just wanted to push it first

adibrastegarnia
adibrastegarnia approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@adibrastegarnia adibrastegarnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeanCondon
When you are done with testing,

@adibrastegarnia adibrastegarnia merged commit 488aba7 into onosproject:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-milkey ray-milkey ray-milkey approved these changes

@adibrastegarnia adibrastegarnia adibrastegarnia approved these changes

@kuujo kuujo Awaiting requested review from kuujo

Assignees

@SeanCondon SeanCondon

Labels
bug 🪲 Something isn't working
Milestone
Aether 2020Q3
Development

Successfully merging this pull request may close these issues.
3 participants
@SeanCondon @adibrastegarnia @ray-milkey