JUnit reporter does not create directory before creating file.

[wingyplus]

When call RunSpecsWithCustomReporters with not current directory and it doesn't exist. Ginkgo print an error and stop running:

Failed to create JUnit report file: /tmp/not_exists_folder/junit.xml
	open /tmp/not_exists_folder/junit.xml: no such file or directoryFailed to generate JUnit report
	invalid argumentPASS

Ginkgo ran 1 suite in 930.288973ms
Test Suite Passed

I can produce this issue by this code below:

package main

import (
	"testing"

	"github.com/onsi/ginkgo"
	"github.com/onsi/ginkgo/reporters"
	"github.com/onsi/gomega"
)

func TestSuite(t *testing.T) {
	rpts := []ginkgo.Reporter{
		reporters.NewJUnitReporter("/tmp/not_exists_folder/junit.xml"),
	}

	gomega.RegisterFailHandler(ginkgo.Fail)
	ginkgo.RunSpecsWithCustomReporters(t, "Suite", rpts)
}

var _ = ginkgo.Describe("first", func() {
	ginkgo.It("do something", func() {
	})
})

I have workaround solution by called mkdir before run spec. But I think it would be nice if ginkgo can create directory before create a filename.

[onsi]

This will be fixed in v2

[jlojosnegros]

Migrating to v2 but still having this issue

./bin/mybinaryfile.test --ginkgo.v --ginkgo.fail-fast --ginkgo.junit-report=/tmp/artifacts/report --ginkgo.focus='my desired tests'

Failed to generate JUnit report:
  open /tmp/artifacts/report: no such file or directory
  In [ReportAfterSuite] at: vendor/github.com/onsi/ginkgo/v2/reporting_dsl.go:127

[onsi]

hey - you can use:

./bin/mybinaryfile.test --ginkgo.v --ginkgo.fail-fast --ginkgo.junit-report=report --ginkgo.focus='my desired tests' --ginkgo.output-dir=/tmp/artifacts

[jlojosnegros]

hey - you can use:

./bin/mybinaryfile.test --ginkgo.v --ginkgo.fail-fast --ginkgo.junit-report=report --ginkgo.focus='my desired tests' --ginkgo.output-dir=/tmp/artifacts

Thanks for the hint :) . Sadly something did not work.

Running this script:

echo "Ginkgo version: " `ginkgo version`
./bin/mybinaryfile.test --ginkgo.v --ginkgo.fail-fast --ginkgo.output-dir=/tmp/artifacts --ginkgo.junit-report=report --ginkgo.focus='my desired tests'

Got this:

Ginkgo Version:  Ginkgo Version 2.1.4                                
flag provided but not defined: -ginkgo.output-dir                                         
Controlling Test Order                                                    
  --ginkgo.seed [int] (default: randomly generated by Ginkgo)
    The seed used to randomize the spec suite.                                           
  --ginkgo.randomize-all                                                       
    If set, ginkgo will randomize all specs together.  By default, ginkgo only
    randomizes the top level Describe, Context and When containers.
    
    .... this continue with all the supported flags

[onsi]

dump, so sorry. I was moving too fast when I replied. the output-dir flag is only available on the CLI (which moves the generated report file after it is written by the test process). so you can do:

ginkgo -v -fail-fast -junit-report=report -focus='my desired tests' -output-dir=/tmp/artifacts ./bin/mybinaryfile.test

You're now probably thinking "that sounds incredibly dumb" which... fair. what's happening here is the workflow is optimized for running multiple suites that each generate a report and then collating those reports into a single file (or a set of files) all in one location. That collation is done by the cli (it has to be - each suite is a separate go test binary so it's the CLI that orchestrates running them and merging artifacts)... what isn't currently supported is specifying output-dir for a single suite with the suite's config flags. unit-report also doesn't support absolute paths though this is something I might fix later, I'm just now going to be able to get to it for a bit.