Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change interface{} to any and update to go 1.20 #1203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ehsandavari
Copy link

No description provided.

@blgm
Copy link
Collaborator

blgm commented May 23, 2023

I think this is the right direction, but there is an issue around timing. Go 1.19 is still in support, and many folks are on older versions. Although Ginkgo only supports the Go versions in support, in the past we have tried not to break folks who are a little out of date where the cost of doing that is low.

  • any was introduced in Go 1.18, so my personal opinion is that it would be ok to merge this part
  • As Go 1.19 is still in support, I'd suggest that the update to Go 1.20 is not merged at this stage because it would break some people and doesn't introduce any advantage. Eventually we will need this, but I don't think we need it yet.

But these are my personal opinions, and @onsi is the maintainer of this project.

@onsi
Copy link
Owner

onsi commented May 28, 2023

hey @ehsandavari thanks for this - I agree with @blgm

dropping interface{} for any makes sense and the timing is right. We should hold off on any changes that require 1.20 until 1.19 is out of support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants