-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Update recommender page design #433
Feature: Update recommender page design #433
Conversation
a10f6de
to
cd0c01c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work for the most part. You have started to become an expert in Stimulus and ViewComponent. I have added some feedback and remarks for you to consider.
9e2ccc3
to
e95928f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, for most of the parts; some little requested changes,
But I don't think that the Rai/Rap music; in the demo was necessary.
Hhhh btw I didn't notice the music in the demo, thanks for giving me a heads-up 😂 |
All the rets is good @Bilelkihal congrats! |
Aussi @Bilelkihal est-ce que tu as géré l'information a donné aq l'utilisateur si il choisi keywords |
…and UI JS code migration (#432) * Feauture: Update admin page and fix google analytics (#422) * remove no more used ontologies.js file * add id argument to the alert component * justify center tabs items if no actions button are pinned_right * install latest version of Chart JS and create chart_component helper * add Analytics section to the admin page * catch the case were the analytics are not existent * Fix: Google Analytics 4 tag (#424) * revert the change in ontologies_analytics to use last month analytics * Merge pull request #271 from ncbo/feature/ga4-migration/270 Universal Analytics -> Google Analytics 4 migration * Feature: add SPARQL endpoint UI (#427) * add yasgui dependency to have a SPARQL editor * add sparql ednpoint proxy action * add SPARQL section to the admin page * add SPARQL section to the ontology viewer * Feature: add satistics page (#428) * upgrade the chart helpers to have more options as show legend, title, .. * add statistics page * add link to statistics page in home page * Fix: remove old JS dependecies (#429) * remove select2 dependency * remove jquery.tooltip dependency as not used * remove fg.menu dependency as not used * remove the usage of the of chart-js gem replaced with esbuild * remove jquery dependency scrollTo and replaced with native JS * remove no more used JS dependencies * remove no more used JS code * remove margin notes remaining code * optimize the json search action * Feature: add synchronize groups to slices button in admin page (#418) * update the js file, add button and ajax action * add synchronize_groups function and GROUPS_SYNCHRONIZE_URL url * add the route of synchronize_groups * remove old jquery validate code of groups --------- Co-authored-by: Syphax Bouazzouni <gs_bouazzouni@esi.dz> * Feature: Add icons to display orcid, and affiliations in agent tooltip (#420) * Add icon to display orcid, and affiliations in agent tooltip * add organization dependencies icon in agent tooltip * Feature : create a new component to display tree views (#307) * Add tree link component and refactor the code * update concept controller to use the tree component and remove old code * use tree link component for concept list by date and collection * remove old code no more used * update tree link component to be have more generic arguments * update tree view component to use tree link component * add tree component helper * make tree_infinite_scroll use tree view component * add concept tree view helper and use in concept controller to show tree * update concept list and date sorted views to use tree view component * add a card style to the schemes and collection tree views * use the tree view component for the schemes and collections * migrate properties tree to the ruby tree view component * remove no more used properties tree js code * put again the removed splitter assets blocking history to work * remove this usage of histroy.js and replace with the native one * remove jquery simple tree dependency * add tree view links controller tests --------- Co-authored-by: Syphax bouazzouni <gs_bouazzouni@esi.dz> * Feature: update Widgets section design to remove thickbox (#430) * remove old code of reviews feature * update widgets section style to to remove thickbox dependecy * remove jQuery block UI dependecy replaced with the Turbo progress bard * Feature: Remove Facebox from instances, admin submissions, categories, groups and mappings (#431) * migrate instances modal from facebox to turbo modal * migrate admin submission modal from facebox to turbo modal * migrate mapping modal from facebox to turbo modal * migrate categories from JS code to ruby and remove facebox usage * migrate groups admin JS code to ruby and remove the usage of facebox * remove the dependency facebox * replace js required fields validation with native html require * force popup link svg to always be filled with the primary color not dark * remove agent table list partial move its content to directly index * move admin action buttons to the the backend * migrate admin user table to backend and remove the js code * clean admin routes * migrate agents, users, groups, and categories tables to table component * remove facebox dependency files * Feature: Update search page design (#412) * search page new icons * search page new input style * search page new input and advanced options html * search page js controller * Make search result component and add it to search page * add search result subcomponent * Add search page logic * show results id correctly in search page * display ontology name and acronym correctly in search page * make search elements links work in search page * fix api query param error in search page * show search results definition correctly * make search page ui take all width * add empty state to search page * add search result component js * Filter Perflabs to take the most close to the search input in search page * use turbo rails in search page * get all the results from the search api in one page in search page * make search page filters work * Add ontology reuses logic * make details and visualize buttons work in seach page * add class reuses to search result component in search page * add reuses to result structure in search page * add reuse decendents in search page * Make search result component and add it to search page * add search result subcomponent * Add search page logic * show results id correctly in search page * display ontology name and acronym correctly in search page * make search elements links work in search page * fix api query param error in search page * show search results definition correctly * make search page ui take all width * add empty state to search page * add search result component js * Filter Perflabs to take the most close to the search input in search page * use turbo rails in search page * get all the results from the search api in one page in search page * make search page filters work * Add ontology reuses logic * make details and visualize buttons work in seach page * add class reuses to search result component in search page * add reuses to result structure in search page * add reuse decendents in search page * fix bugsnag gem configuration * simplify search result component by inferring some arguments * use d-flex bootstrap call instead options in the search result component * simplify the search parameters key naming to avoid duplication * convert all the functions the bp_search.js to search_aggregator.rb * extract details and vizualize buttons to functions, in search result component * fix ontologies filter and remove categories filter in search page * Clean search result component stimulus controller code * remove categories translation on search page * extract reveal ontologies buttons to a function in search result component * remove duplicated annotator_recommender_form function from home controller * make a generic stimulus controller for reveal by id * make a stimulus controller for reveal with double button * extent reveal component controller to combine all reveal controllers * remove stimulus reveal package * fix the display of obsolete class (#419) Co-authored-by: Syphax bouazzouni <gs_bouazzouni@esi.dz> * Fix: new Search page issues (#436) * fix search page query bug * fix search page filters issues * search resuses decendences reveal issues in search page * make search page multilang * Fix: home page issues (#417) Fix home page issues * Fix: content and aesthetics globally to add help text and action icons (#435) * open the link after clicking in a new tab * add the icon of service link * update the text * update the section Ontology relations network * fix the display of portal name * capitalize items in support section * add fullscreen icon * convert dates * Remove points in feeback page * fix local variables * add icones (edit/delete) in action * change the display of items in property tab * fix style of fair scores button * add a logic to open DropdownContainerComponent * use has_ontology_language_input to refactor * change the text of tooltip * change the title of modal * add help text to switch input component * add helper text in edit submissions and delete the icon of url * fix the full screen width and style * change the text in the sort by * make the admin page on the center * fix the style of some classes on the admin, browse and edit submission page * fix bug of the wrong uri in users section of admin page * add a function to generate link_title with style * add the modified line * add the removed line * Add a style to center the actions in both cases, whether the user is logged in or not. * delete the change of style in tab_container * add help text under version information in edit submission * change convert_dates into concept details component * remove convert_dates from the wrong place * move generate_link_title to right place * remove the wrong modification * add new component IconWithTooltipComponent * use the IconWithTooltipComponent to display icons with text * adjust the icon size to be compatible with all icons in the portal * remove the not used functions * update the select in edit submissions with reveal component * remove the show icon condition from summary section component * add fairness_link function into helper * Reuse fairness_link with style * add functions for edit and service action * fix submission success message typo * update reveal component to handle multiple containers * update ontology_language, visibility, status and view of to use the new reveal * rescue concept details converted date parsing exceptions * use generic variable for the colors of the ontology relation title * make the notes metadata attribute long text * add custom help text to deprecated metadata property --------- Co-authored-by: Syphax bouazzouni <gs_bouazzouni@esi.dz> * Feature: Update recommender page design (#433) * make radio chip component * udpate the design of recommender page inputs * make radio chip selected initially * make number component and add it to lookbook * add recommender page advanced options * add advanced options revreal to recommender page * handle recommender keywords input text area in recommender page * add results table in recommender page * add sort parameter to option component * make progress bar component * fix recommender page results section style * display recommender page results * add default sorting column in table component * heighlight the row with max final score in recommender page * highlight selected annotations in text recommendation area in recommender page * make edit work in recommender page * make filters work in recommender page * do logic of ontologies and ontologies sets on recommener page * define constraints for the inputs (mins and maxes) in recommender page * limit recommender input text size by 500 char * make insert sample text work in recommender page * add cite button in recommender page * remove get annotations button in recommender page * add recommender cite url * use stimulus values in table component * clean recommender page controllers code * add recommender page texts to local lang files * make advancced options open by default when it's not empty in recommender page * clean recommender page controllers code * remove recommender old jQuerry file * fix bioportal config test to add the new $HOME_PAGE_LOGOS * put again the custom class argument in the table component --------- Co-authored-by: Syphax Bouazzouni <gs_bouazzouni@esi.dz> * Feature: Add URL resolvability checker (#463) * add URL resolvability check icon component * add the resolvability check icon to link field component * optimize metadata curator result rendering by using collection * add click action event in the reveal component * extract check resolvability helpers file * add check resolvability tool page * add copy to clipboard component * use clipboard component an account copy apikey * remove unused uri.js file * add copy to clipboard option to the link fields component * fix check resolvability to do follow redirection by format * add clipboard and resolvability to concept details pages * move check_resolvability action to CheckResolvabilityController * move check_resolvability_container to components helper * fix link field component style width after adding the two action icons * fix SKOS collections colors not removing all dots (#465) * Fix: Add slider component to recommender page (#466) * clean recommender controller from unused code * Make ‘select ontologies’ before ‘max ont set’ * Maximize the limite of the input text length in recommender page (9678 char) * Add text area resize to recommender input * make range slider component * validate max_elements_set input in recommender page (valid values are 2,3,4) * Add json and annotator buttons in recommender page * Feature: Add keywords tooltip in Recommender page (#471) * Add keywords tooltip in recommender page * change annotator button text in recommender page * Fix: metadata exporter to different formats (CSV, xml, json and ntriples) (#469) * fix ontology viewer tabs style * extract content_metadata_attributes helper from submissions component * add html_safe to date time component to handle the console warnings * add metadata exporter controller * refactor metadata downloader stimulus to fix prefixes and add csv * remove show_additional_metadata action and code * humanize admin page tabs tabs titles * Feature: enable multilingual to the properties tab (#470) * enable multilingual to the properties tab * handle the case propertyid is nil error --------- Co-authored-by: SirineMhedhbi <31127782+SirineMhedhbi@users.noreply.github.com> Co-authored-by: Bilel Kihal <61744974+Bilelkihal@users.noreply.github.com>
Problem
1 - The page has an old UI
2 - Same problem of old js codes see: #426
Done in this PR:
recommender.demo.mp4