Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ObjectStorageS3 configuration to include Token #424

Conversation

bsriramprasad
Copy link
Contributor

@bsriramprasad bsriramprasad commented May 22, 2024

Ref: https://www.onvif.org/ver10/device/wsdl/devicemgmt.wsdl

  • tt:UserCredential element used to access ObjectStorageS3 has only two fields, UserName and Password. This is not enough to access an S3 Bucket through an AWS STS (Security Token Service). For this the client needs to provide
    • Access key ID (username)
    • Secret access key (password)
    • Session token

We thus propose that we add an additional field for the session token for ObjectStorageS3 storage configuration type.

@bsriramprasad bsriramprasad changed the title Video/extend s3storage config sts token Extend ObjectStorageS3 configuration to include Token May 22, 2024
Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this update, I am sure it will be discussed further but on reading the same I am happy to approve this.

jmelancongen added a commit to jmelancongen/specs that referenced this pull request Jun 3, 2024
@bsriramprasad bsriramprasad marked this pull request as ready for review July 25, 2024 12:53
@HansBusch HansBusch merged commit e93648f into onvif:development Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants