-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing buttons on both Country and Measurement pages #476
Conversation
Great job on this! I have some suggestions about the design. The issues I see with the current approach are:
To this end I propose the following designs which I think address all the points above: The share icon should be inside of the material design icon set and it's called Let me know if you have any questions about the implementation. |
TODO, following call with @sarathms:
|
Wrong issue. See: #480 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work @kronaemmanuel ! Thanks for putting it together.
I checked the screenshots and it looks good to me!
@sarathms can you deploy this to our testing instance of OONI Explorer so I can do some functional testing as well, before we deploy it in production?
Deployed. Note that it had to be merged with the branch using test API server. |
Also the social media previews may not look as good without the other metatag changes. Especially on Facebook. |
@hellais Did you see the preview on explorer-test? Shall we merge this and consider tweaks for another PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge 🐳
Things to be discussed: