Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metatag og:image in country and measurement pages #480

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Metatag og:image in country and measurement pages #480

wants to merge 9 commits into from

Conversation

kronaemmanuel
Copy link
Contributor

This PR includes the commits for og:image in country and measurement pages.

Screenshots

  • Country Page
    image
  • Measurement Page:
    image

@sarathms
Copy link
Contributor

  • prefetch
    just occurred as a passing thought. adding this here just in case I forget to mention it later when this PR is ready for formal review

hellais
hellais reviewed Aug 26, 2020
View reviewed changes
pages/measurement.js Outdated
}){
const origin =
typeof window === 'undefined'
? 'https://explorer.ooni.com'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo

@hellais
Copy link
Member

hellais commented Aug 26, 2020

Next steps:

  • We are going to drop the flags from the screenshots
  • Check the performance of puppeteer
  • TODO(@kronaemmanuel) Disable the API endpoints for screenshotting prior to merge and ensure the attack surface is not increased
  • Before re-enabling API endpoints we should have done a security audit of the code
  • TODO(@hellais): Finalise the mockups for the country page screenshot without the country flag & also for the measurement page without the flag

@hellais
Copy link
Member

hellais commented Aug 26, 2020 •
edited

Final mockup for the country page screenshot:

Country page screenshot

@hellais hellais mentioned this pull request Aug 26, 2020
Merged
@sarathms sarathms self-requested a review September 15, 2020 14:38
@sarathms sarathms removed this from the Sprint 27 - Hexacorallia milestone Dec 7, 2020
@hellais hellais removed this from the Sprint 50 - Amphipoda milestone Oct 25, 2021
@agrabeli agrabeli mentioned this pull request Oct 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais hellais left review comments

@sarathms sarathms Awaiting requested review from sarathms

At least 1 approving review is required to merge this pull request.

Assignees

@sarathms sarathms

Labels
priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kronaemmanuel @sarathms @hellais @bassosimone