Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Designs] Implemtent add link flow #641

Closed

Conversation

aanorbel
Copy link
Contributor

Fixes ooni/probe#2595

Proposed Changes

aanorbel and others added 18 commits November 21, 2023 08:38
…nceManagerExtension.kt

Co-authored-by: Simone Basso <bassosimone@gmail.com>
…e/migrate-dashboard-and-overview-to-descriptors
Fixes  ooni/probe#2596

## Proposed Changes

  - Update designs for Run v1 components to match new designs
  - Add `SrtingListRecyclerViewAdapter` to display List items
  - Convert `OoniRunActivity` to Kotlin
  
| Light | Dark|
|--|--|
|.|.|

|![web_connectivity_light](https://github.com/ooni/probe-android/assets/17911892/6f4b5896-c85a-4cd9-8fb2-0f6eb693f38e)|![web_connectivity_dark](https://github.com/ooni/probe-android/assets/17911892/6a30f612-1b42-4e43-b8e5-0f4a16edf86b)|

|![web_connectivity_light_long_list](https://github.com/ooni/probe-android/assets/17911892/9d871137-fd3b-4b23-9c3a-700d30d43f6b)|
![web_connectivity_dark_long_list](https://github.com/ooni/probe-android/assets/17911892/82c0d8fa-c0b6-4ed1-83ef-607c4bf952c4)|

|![web_connectivity_light_short_list](https://github.com/ooni/probe-android/assets/17911892/42e96ad5-318b-4220-beae-d5d8932da985)|![web_connectivity_dark_short_list](https://github.com/ooni/probe-android/assets/17911892/7aafa54c-5498-40d2-8cbb-f00173e001ee)|

|![http_header_field_manipulation_light](https://github.com/ooni/probe-android/assets/17911892/c79e07be-9044-4cf9-9272-b4be0a6f6d4f)|![http_header_field_manipulation_dark](https://github.com/ooni/probe-android/assets/17911892/d4cb96ed-c6a5-4e55-9a9b-7f47059fde3f)|

|![invalid_light](https://github.com/ooni/probe-android/assets/17911892/05516448-7094-484d-9ccb-f118f489e546)|![invalid_dark](https://github.com/ooni/probe-android/assets/17911892/bc5351fa-770f-43d8-aa65-5265ba4c1cad)|

|![outdated_light](https://github.com/ooni/probe-android/assets/17911892/e475971e-23c0-4f37-9ee1-598ce91bb611)|![outdated_dark](https://github.com/ooni/probe-android/assets/17911892/a94e5849-3eeb-4ad1-a393-4591d5d0f824)|

|![whatsapp_light](https://github.com/ooni/probe-android/assets/17911892/3f9b5760-a259-4838-a28c-1d8db1e8ceed)|![whatsapp_dark](https://github.com/ooni/probe-android/assets/17911892/2313ca90-b5ab-4bb1-ac13-7cc763bc06eb)?
…e/migrate-dashboard-and-overview-to-descriptors
…o chore/migrate-dashboard-and-overview-to-descriptors
Fixes ooni/probe#2592

## Proposed Changes

  - Updated `CustomWebsiteActivity` to use new theme.
  - Change List item builder to use  `RecyclerView`.


Tasks

- [x] Implement designs on light theme.
- [x] Convert list item builder to  use  `RecyclerView`.
- [x] Fix dark theme
- [x] Implement modal properly

| Light | Dark|
|-|-|

|![Screenshot_20231104_110235](https://github.com/ooni/probe-android/assets/17911892/b4c8dca7-2c6a-4d55-9df4-f194a67b98a6))|
![Screenshot_20231104_110254](https://github.com/ooni/probe-android/assets/17911892/60ade191-40bb-4b0b-a5fa-aa93540bd112)
|

|![Screenshot_20231104_110336](https://github.com/ooni/probe-android/assets/17911892/2df8c97a-23ff-4771-970b-59044de00386)|
![Screenshot_20231104_110407](https://github.com/ooni/probe-android/assets/17911892/291af536-72e3-4774-a5ca-8301334543a0)
|
|
![Screenshot_20231104_110429](https://github.com/ooni/probe-android/assets/17911892/a7423372-5acd-45b8-aa0a-ae2ef4e4b62c)
|
![Screenshot_20231104_110441](https://github.com/ooni/probe-android/assets/17911892/15047e19-9c3e-4cbe-a1c1-ceaa8783da8a)
|

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>
…o chore/migrate-dashboard-and-overview-to-descriptors
@aanorbel aanorbel closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant