Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: do not cross compile miniooni #2119

Closed
bassosimone opened this issue May 30, 2022 · 1 comment
Closed

build: do not cross compile miniooni #2119

bassosimone opened this issue May 30, 2022 · 1 comment
Assignees
@bassosimone
Labels
data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/medium refactoring

Comments

@bassosimone
Copy link
Contributor

This issue is about rewriting the mk build system to not cross compile miniooni. We explained in ooni/probe-cli#766 why we should not cross compile for better system resolver's accuracy. By not cross compiling, we can call getaddrinfo directly. In turn, this allows us to collect the getaddrinfo return code and the CNAME.
@bassosimone bassosimone added enhancement improving existing code or new feature priority/medium refactoring methodology issues related to the testing methodology data quality ooni/probe-engine labels May 30, 2022
@bassosimone bassosimone self-assigned this May 30, 2022
This was referenced May 30, 2022
Merged
Draft
Open
@bassosimone bassosimone mentioned this issue Jun 6, 2022
Open
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 30, 2022
@bassosimone
feat: stop cross compiling miniooni
0179ae0 
See ooni/probe#2119

While there, shrink the Makefile to only export the minimum
set of rules to comfortable build using GHA.
@bassosimone bassosimone mentioned this issue Aug 30, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 30, 2022
@bassosimone
feat: stop cross compiling miniooni (#908)
0d57899 
See ooni/probe#2119

While there, shrink the Makefile to only export the minimum
set of rules to comfortable build using GHA.
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 30, 2022
@bassosimone
fix: attempt to make android builds faster
3d7ed8a 
After #908, the Android
build has become super slow, because we build serially.

Attempt to make it faster by building in parallel.

Still part of ooni/probe#2119, because
I don't feel happy with a super slow build.
@bassosimone bassosimone mentioned this issue Aug 30, 2022
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Aug 30, 2022
@bassosimone
fix: attempt to make android builds faster (#909)
d1b172f 
After #908, the Android
build has become super slow, because we build serially.

Attempt to make it faster by building in parallel.

Still part of ooni/probe#2119, because
I don't feel happy with a super slow build.
@bassosimone
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
data quality enhancement improving existing code or new feature methodology issues related to the testing methodology ooni/probe-engine priority/medium refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone