Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oohelper): unnest and simplify #2133

Open
4 tasks
bassosimone opened this issue Jun 8, 2022 · 2 comments
Open
4 tasks

refactor(oohelper): unnest and simplify #2133

bassosimone opened this issue Jun 8, 2022 · 2 comments
Assignees
Labels

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Jun 8, 2022

While working on ooni/probe-cli#805, I noticed that oohelper's implementation could really use a cleanup and refactoring. Here's what we should roughly do:

  • unnest the implementation (long time ago, I was creating many small interconnected packages while now I have settled on creating a large, flat set of packages)
  • make sure we're using unit tests rather than integration tests
  • we should use mocks from internal/model/mocks rather than rolling out our own mocks
  • if we need integration tests, we should be testing against the oohelperd implementation in the same codebase

This refactoring is not very important because the existing code is working ~fine, but would improve the state of the tree.

@bassosimone bassosimone self-assigned this Jun 8, 2022
@bassosimone
Copy link
Contributor Author

Turns out we already did this but forgot to close the issue!

@bassosimone
Copy link
Contributor Author

My mistake, this is about oohelper and not oohelperd 😢

@bassosimone bassosimone reopened this Aug 28, 2022
@bassosimone bassosimone changed the title refactor: unnest and simplify oohelper implementation refactor(oohelper): unnest and simplify Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant