Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniooni: allow arbitrary OONI Run v2 options #2759

Closed
bassosimone opened this issue Jun 27, 2024 · 0 comments · Fixed by ooni/probe-cli#1629
Closed

miniooni: allow arbitrary OONI Run v2 options #2759

bassosimone opened this issue Jun 27, 2024 · 0 comments · Fixed by ooni/probe-cli#1629
Assignees
Labels
cleanup There's need to cleanup stuff a bit enhancement improving existing code or new feature funder/otffoss2023-2024 ooni/probe-engine priority/high refactoring techdebt This issue describes technical debt

Comments

@bassosimone
Copy link
Contributor

This diff is about improving upon the ./internal/oonirun package such that we can provide any JSON document as the options for an experiment, rather than limiting ourselves to scalars, as it's currently the case. This change would effectively remove technical debt and enable experiments to specify more complex sets of options through OONI Run v2. In turn, this would also be beneficial for the richer input strategy. Please, note that, after this change, there's no need anymore to use ooni:"..." to mark options that we would like to set. Setting through JSON will always be possible. Instead, now the ooni:"..." tag is just meant to show which options one could set using the -O name=value flag from the command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup There's need to cleanup stuff a bit enhancement improving existing code or new feature funder/otffoss2023-2024 ooni/probe-engine priority/high refactoring techdebt This issue describes technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant