Skip to content

chore: update foreach to count #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2022
Merged

chore: update foreach to count #14

merged 2 commits into from
Nov 23, 2022

Conversation

xshot9011
Copy link
Contributor

@xshot9011 xshot9011 commented Nov 23, 2022 •
edited
Loading

Submit a pull request 🚀

Thank you for help us contribute! Please give us more information about this PR.

What 😗

Changed

  • Update example usage for examples/complete/* and examples/simple/*
  • Update meta-argument of resource aws_iam_role_policy_attachment.this from for_each to count
  • Update variable additional_lambda_role_policy_arns from type map(string) to list(string)

Why 🥺

  • Prevent resource not exist on terraform first apply

@xshot9011 xshot9011 marked this pull request as ready for review November 23, 2022 10:13
@xshot9011 xshot9011 merged commit b52e870 into main Nov 23, 2022
@xshot9011 xshot9011 deleted the chore/update-for-each-to-count branch November 23, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bemillenium bemillenium bemillenium approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xshot9011 @bemillenium