Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TypeScript strict mode #374

Merged
merged 17 commits into from Nov 13, 2022
Merged

Enable TypeScript strict mode #374

merged 17 commits into from Nov 13, 2022

Conversation

gustavohenke
Copy link
Member

@gustavohenke gustavohenke commented Oct 15, 2022

As title says. Addressing #372 (comment) 馃槈

bin/concurrently.spec.ts Show resolved Hide resolved
src/command.ts Show resolved Hide resolved
src/command.ts Show resolved Hide resolved
src/completion-listener.ts Show resolved Hide resolved
src/concurrently.ts Show resolved Hide resolved
@gustavohenke

This comment was marked as resolved.

@coveralls
Copy link

coveralls commented Oct 15, 2022

Coverage Status

Coverage decreased (-0.4%) to 99.644% when pulling 381676d on ts-strict into 07e8223 on main.

@gustavohenke gustavohenke merged commit 5fbc61c into main Nov 13, 2022
26 checks passed
@gustavohenke gustavohenke deleted the ts-strict branch November 13, 2022 06:37
@gustavohenke
Copy link
Member Author

Let me know of any changes you think might be useful, @paescuj 馃檪

@paescuj
Copy link
Collaborator

paescuj commented Nov 13, 2022

Thanks for taking this on and sorry for my late reply! Looks solid 馃憤馃槂

fwouts pushed a commit to fwouts/previewjs that referenced this pull request Nov 25, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[open-cli-tools/concurrently#375
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#374
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[open-cli-tools/concurrently#376
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[open-cli-tools/concurrently#385

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[open-cli-tools/concurrently#375
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[open-cli-tools/concurrently#376

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

馃搮 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

馃殾 **Automerge**: Enabled.

鈾 **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

馃敃 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMzMuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot added a commit to defenseunicorns/zarf that referenced this pull request Nov 25, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### 鈿 Dependency Lookup Warnings 鈿

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[open-cli-tools/concurrently#375
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#374
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[open-cli-tools/concurrently#376
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[open-cli-tools/concurrently#385

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[open-cli-tools/concurrently#375
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[open-cli-tools/concurrently#376

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

馃搮 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

馃殾 **Automerge**: Enabled.

鈾 **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

馃敃 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Noxsios pushed a commit to defenseunicorns/zarf that referenced this pull request Mar 8, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### 鈿 Dependency Lookup Warnings 鈿

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[open-cli-tools/concurrently#375
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[open-cli-tools/concurrently#374
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[open-cli-tools/concurrently#376
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[open-cli-tools/concurrently#385

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[open-cli-tools/concurrently#375
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[open-cli-tools/concurrently#376

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

馃搮 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

馃殾 **Automerge**: Enabled.

鈾 **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

馃敃 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants