New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update install command to use `--save-dev` #376

Merged

paescuj merged 1 commit into open-cli-tools:main from DetachHead:patch-1

Nov 13, 2022

Contributor

DetachHead commented Oct 31, 2022

concurrently is a dev tool so it should be saved to devDependencies


          update install command to use --save-dev

64b5a06

gustavohenke reviewed

View reviewed changes

Member

gustavohenke left a comment

It's arguable.

Using concurrently to spin up multiple build tools at once is pretty common, so it fits correctly the description of a dev tool.

On the other hand, you could have multiple services in a production server that need to be respawned when one of them dies.
I'm not saying that this is a good practise, but it's a valid use case for concurrently.

@paescuj opinions?

Collaborator

paescuj commented Nov 13, 2022

I'm in favor of this change for the following two reasons:

I assume that in a majority of projects "concurrently" is indeed used as a development tool.
It feels safer to propose the installation as devDependency by default.

I'm not saying that this is a good practise, but it's a valid use case for concurrently.

I also think this is a valid use case, but let's leave it to the users to declare "concurrently" as a productive dependency in this case.

paescuj merged commit 9aa13aa into open-cli-tools:main

fwouts referenced this pull request in fwouts/previewjs


          chore(deps): update dependency concurrently to v7.6.0 (#1234)

db1a774

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[https://github.com/open-cli-tools/concurrently/pull/375](https://togithub.com/open-cli-tools/concurrently/pull/375)
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[https://github.com/open-cli-tools/concurrently/pull/374](https://togithub.com/open-cli-tools/concurrently/pull/374)
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[https://github.com/open-cli-tools/concurrently/pull/376](https://togithub.com/open-cli-tools/concurrently/pull/376)
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[https://github.com/open-cli-tools/concurrently/pull/385](https://togithub.com/open-cli-tools/concurrently/pull/385)

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[https://github.com/open-cli-tools/concurrently/pull/375](https://togithub.com/open-cli-tools/concurrently/pull/375)
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[https://github.com/open-cli-tools/concurrently/pull/376](https://togithub.com/open-cli-tools/concurrently/pull/376)

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMzMuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate bot referenced this pull request in zarf-dev/zarf


          Update dependency concurrently to v7.6.0 (#1029)

a55f0fd

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[https://github.com/open-cli-tools/concurrently/pull/375](https://togithub.com/open-cli-tools/concurrently/pull/375)
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[https://github.com/open-cli-tools/concurrently/pull/374](https://togithub.com/open-cli-tools/concurrently/pull/374)
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[https://github.com/open-cli-tools/concurrently/pull/376](https://togithub.com/open-cli-tools/concurrently/pull/376)
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[https://github.com/open-cli-tools/concurrently/pull/385](https://togithub.com/open-cli-tools/concurrently/pull/385)

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[https://github.com/open-cli-tools/concurrently/pull/375](https://togithub.com/open-cli-tools/concurrently/pull/375)
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[https://github.com/open-cli-tools/concurrently/pull/376](https://togithub.com/open-cli-tools/concurrently/pull/376)

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate bot mentioned this pull request

Lock file maintenance bundling fixtures mui/material-ui#33353

Closed

1 task

Noxsios referenced this pull request in zarf-dev/zarf


          Update dependency concurrently to v7.6.0 (#1029)

e6f93ab

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [concurrently](https://togithub.com/open-cli-tools/concurrently) |
[`7.5.0` ->
`7.6.0`](https://renovatebot.com/diffs/npm/concurrently/7.5.0/7.6.0) |
[![age](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/compatibility-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/concurrently/7.6.0/confidence-slim/7.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>open-cli-tools/concurrently</summary>

###
[`v7.6.0`](https://togithub.com/open-cli-tools/concurrently/releases/tag/v7.6.0)

[Compare
Source](https://togithub.com/open-cli-tools/concurrently/compare/v7.5.0...v7.6.0)

#### What's Changed

- Support percent values in maxProcesses by
[@&#8203;lynxtaa](https://togithub.com/lynxtaa) in
[https://github.com/open-cli-tools/concurrently/pull/375](https://togithub.com/open-cli-tools/concurrently/pull/375)
- Enable TypeScript strict mode by
[@&#8203;gustavohenke](https://togithub.com/gustavohenke) in
[https://github.com/open-cli-tools/concurrently/pull/374](https://togithub.com/open-cli-tools/concurrently/pull/374)
- update install command to use `--save-dev` by
[@&#8203;DetachHead](https://togithub.com/DetachHead) in
[https://github.com/open-cli-tools/concurrently/pull/376](https://togithub.com/open-cli-tools/concurrently/pull/376)
- Correct wildcard naming as described in README by
[@&#8203;paescuj](https://togithub.com/paescuj) in
[https://github.com/open-cli-tools/concurrently/pull/385](https://togithub.com/open-cli-tools/concurrently/pull/385)

#### New Contributors

- [@&#8203;lynxtaa](https://togithub.com/lynxtaa) made their first
contribution in
[https://github.com/open-cli-tools/concurrently/pull/375](https://togithub.com/open-cli-tools/concurrently/pull/375)
- [@&#8203;DetachHead](https://togithub.com/DetachHead) made their first
contribution in
[https://github.com/open-cli-tools/concurrently/pull/376](https://togithub.com/open-cli-tools/concurrently/pull/376)

**Full Changelog**:
open-cli-tools/concurrently@v7.5.0...v7.6.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yOC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjguMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Leo1312424 mentioned this pull request

[Snyk] Upgrade concurrently from 7.5.0 to 7.6.0 Leo1312424/HackMe#4

Open

WontonSam mentioned this pull request

[Snyk] Upgrade concurrently from 6.5.1 to 8.2.2 WontonSam/shopify#37

Open

abdulrahman305 mentioned this pull request

[Snyk] Upgrade concurrently from 7.0.0 to 7.6.0 abdulrahman305/aws-sdk-js-v3#1

Open

mun1013 mentioned this pull request

[Snyk] Upgrade concurrently from 7.0.0 to 7.6.0 mun1013/taxiApp-react-typescript#2

Open

Mark-hub-2323 mentioned this pull request

[Snyk] Upgrade concurrently from 5.3.0 to 8.2.2 Mark-hub-2323/juice-shop#11

Open

WontonSam mentioned this pull request

[Snyk] Upgrade concurrently from 7.6.0 to 8.2.2 WontonSam/woocommerce-admin#328

Open

WontonSam mentioned this pull request

[Snyk] Upgrade concurrently from 7.6.0 to 9.0.1 WontonSam/woocommerce-admin#415

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet