Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fathom UTM parameters for email links tracking #271

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat: add fathom UTM parameters for email links tracking #271

merged 2 commits into from
Feb 28, 2024

Conversation

yolile
Copy link
Member

@yolile yolile commented Feb 28, 2024

@coveralls
Copy link

coveralls commented Feb 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8087075044

Details

  • 0 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 87.62%
Totals Coverage Status
Change from base Build 7990693778: 0.006%
Covered Lines: 2010
Relevant Lines: 2294
💛 - Coveralls

jpmckinney
jpmckinney approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe simpler to hardcode the UTM parameters in the two URLs – it's not really a setting, and we would want to change the utm_source if we wanted to track links from other emails.

@yolile yolile merged commit e526969 into main Feb 28, 2024
5 checks passed
@yolile yolile deleted the fathom branch February 28, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yolile @coveralls @jpmckinney