Add new Dominican Republic scraper #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yolile
requested changes
Sep 2, 2020
| ) | ||
| yield scrapy.Request(url, meta={'file_name': 'page-1.json'}, callback=self.parse_response) | ||
|
|
||
| def parse_response(self, response): |
There was a problem hiding this comment.
the spider is not working as you are not returning anything if the response is 200 here. Also, this should be already covered by the use of handle_http_error so this callback is not necessary
There was a problem hiding this comment.
Yes, I accidentally deleted a line in that function to continue the scraper.
I wanted to give more information to the user in case they enter a date range where there is no data, otherwise, we only show this message:
There was a problem hiding this comment.
I think that 404 error is clear enough but we can add that message to handle_http_error if from_date and/or until_date are used, in another issue
yolile
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #472.