Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge rules as argument #17

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Merge rules as argument #17

merged 2 commits into from
Nov 26, 2018

Conversation

yshalenyk
Copy link
Contributor

@yshalenyk yshalenyk commented Nov 7, 2018 •
edited
Loading

process_schema takes most of the time of merge process, and It's quite slow. So, it's make sense to move it up, and reduce number of calls to it.

@jpmckinney
Copy link
Member

Thanks! I will review next week.

@jpmckinney jpmckinney self-requested a review November 9, 2018 19:35
@jpmckinney jpmckinney merged commit 1f80d09 into open-contracting:master Nov 26, 2018
jpmckinney added a commit that referenced this pull request Nov 26, 2018
@jpmckinney
Merge pull request #18 from open-contracting/pr17
c75ad3b 
Add commits to #17
@jpmckinney
Copy link
Member

Merged, thanks! I took the opportunity to rename process_schema to get_merge_rules, which makes its purpose clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney Awaiting requested review from jpmckinney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yshalenyk @jpmckinney