Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make examples minimal #1680

Open
wants to merge 39 commits into
base: 1.2-dev
Choose a base branch
from
Open

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Feb 28, 2024

closes #1449

Closes #1666

Replaces #1678

Implements proposed improvements from #1449 (comment)

  • Replace 1666-make-examples-minimal with 1.2-dev in handbook

@jpmckinney
Copy link
Member

FYI, I'm resolving conflicts.

@jpmckinney
Copy link
Member

When resolving conflicts, I think my only not-purely-related-to-conflicts changes were:

  • editing the new unsuccessful_tender/tenderUpdate.json to use finalStatus (and lowercase 'unsuccessful`)
  • changing a line in framework_agreements.md about status being 'active' to finalStatus not being set
  • using periods consistently in lists in framework_agreements.md

@duncandewhurst duncandewhurst marked this pull request as ready for review March 27, 2024 23:00
@jpmckinney
Copy link
Member

jpmckinney commented Mar 28, 2024

Other changes while resolving conflicts again:

  • linked_releases.json: Added 'tenderAmendment' release back, to parallel tender.json (even though less minimal).
  • records_reference.md: Updated to mention 3rd release id
  • amendments.md: I had to re-do changes by resolving conflicts, because the commit was squashed in 1449 improve examples #1661 but is unsquashed in this PR

@odscjen
Copy link
Contributor

odscjen commented Apr 17, 2024

@jpmckinney fyi if helpful I'm happy to make any post-review changes that may be needed rather than waiting on @duncandewhurst to return, #1681 and #1685 are both blocked until this PR is merged

@jpmckinney
Copy link
Member

@jpmckinney fyi if helpful I'm happy to make any post-review changes that may be needed rather than waiting on duncandewhurst to return, #1681 and #1685 are both blocked until this PR is merged

I was mid-review when I had to turn my attention to other tasks. I'll hopefully get it done before Duncan returns :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make JSON examples minimal Avoid examples that are incoherent, or that are too abstract
3 participants