-
Notifications
You must be signed in to change notification settings - Fork 42
fix: angular web sdk dependency #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Summary of ChangesHello @lukas-reining, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on dependency management, specifically updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies by modifying package-lock.json
. However, the corresponding package.json
files that triggered these changes are missing from the PR. They should be included for consistency. Additionally, there is a potential peerDependency
issue in the Angular SDK package that could cause runtime problems for consumers. See the specific comment for details.
"@angular/core": "^20.1.2", | ||
"@openfeature/core": "^1.8.1", | ||
"@openfeature/web-sdk": "^1.5.0" | ||
"@openfeature/web-sdk": "^1.6.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This devDependency
is updated to ^1.6.2
, but the peerDependency
for @openfeature/web-sdk
in packages/angular/projects/angular-sdk/package.json
remains ^1.4.1
. If this change is to fix an issue requiring a newer web-sdk
, the peerDependency
should be updated to prevent consumers from using an incompatible older version. For example, it should be changed to ^1.6.2
.
Also, the package.json
files that were modified to produce these package-lock.json
changes should be included in this pull request.
This PR
Related Issues
Fixes #1234523
Notes
Follow-up Tasks
How to test