Skip to content

Conversation

lukas-reining
Copy link
Member

This PR

  • adds this new feature

Related Issues

Fixes #1234523

Notes

Follow-up Tasks

How to test

Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
@lukas-reining lukas-reining requested review from a team as code owners September 30, 2025 12:06
@lukas-reining lukas-reining merged commit 973a79e into main Sep 30, 2025
7 of 10 checks passed
Copy link
Contributor

Summary of Changes

Hello @lukas-reining, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on dependency management, specifically updating the @openfeature/angular-sdk to its latest patch version and ensuring it utilizes a more recent version of the @openfeature/web-sdk. This update propagates the latest features and fixes from the core web SDK into the Angular integration, aiming to improve stability and functionality.

Highlights

  • Angular SDK Version Update: The @openfeature/angular-sdk has been updated from version 0.0.16 to 0.0.17.
  • Web SDK Dependency Update: The @openfeature/angular-sdk's dependency on @openfeature/web-sdk has been updated to ^1.6.2 from ^1.5.0.
  • Web SDK Package Update: The top-level @openfeature/web-sdk package itself has been updated from version 1.6.1 to 1.6.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lukas-reining lukas-reining deleted the fix/angular-web-sdk-dep branch September 30, 2025 12:06
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies by modifying package-lock.json. However, the corresponding package.json files that triggered these changes are missing from the PR. They should be included for consistency. Additionally, there is a potential peerDependency issue in the Angular SDK package that could cause runtime problems for consumers. See the specific comment for details.

"@angular/core": "^20.1.2",
"@openfeature/core": "^1.8.1",
"@openfeature/web-sdk": "^1.5.0"
"@openfeature/web-sdk": "^1.6.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This devDependency is updated to ^1.6.2, but the peerDependency for @openfeature/web-sdk in packages/angular/projects/angular-sdk/package.json remains ^1.4.1. If this change is to fix an issue requiring a newer web-sdk, the peerDependency should be updated to prevent consumers from using an incompatible older version. For example, it should be changed to ^1.6.2.

Also, the package.json files that were modified to produce these package-lock.json changes should be included in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant