-
Notifications
You must be signed in to change notification settings - Fork 42
chore(main): release angular-sdk 0.0.10 #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(main): release angular-sdk 0.0.10 #1255
Conversation
Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Summary of ChangesHello @openfeaturebot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves as an automated release for version "0.0.10" of the OpenFeature Angular SDK. It consolidates a significant number of updates, including expanded Angular version compatibility (18, 19, 20), new capabilities like initial context injection, and various bug fixes and documentation enhancements. Notably, this release also corrects the version number in several project files, reverting it from "0.0.17" to the intended "0.0.10". Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by release-please, appears to have a critical issue. It is attempting to downgrade the angular-sdk
version from 0.0.17
to 0.0.10
, which is against semantic versioning principles. This is reflected in package.json
, .release-please-manifest.json
, and README.md
. Additionally, the CHANGELOG.md
is being updated with a new, incorrect entry for 0.0.10
that has an invalid comparison link and aggregates changes from multiple previous versions, creating confusion and corrupting the release history. This suggests a significant error in the release automation configuration that should be addressed before merging.
"packages/server": "1.19.0", | ||
"packages/shared": "1.9.1", | ||
"packages/angular/projects/angular-sdk": "0.0.17" | ||
"packages/angular/projects/angular-sdk": "0.0.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Changelog | ||
|
||
|
||
## [0.0.10](https://github.com/open-feature/js-sdk/compare/angular-sdk-v0.0.17...angular-sdk-v0.0.10) (2025-09-30) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new release entry for version 0.0.10
is incorrect and will corrupt the project's release history for several reasons:
- The comparison link
.../compare/angular-sdk-v0.0.17...angular-sdk-v0.0.10
is invalid for a new release. It should compare the previous version tov0.0.10
. - The changelog contents appear to be an aggregation of many previous versions, not just the changes for this specific release.
- An entry for
v0.0.10
already exists further down in this file.
This indicates a critical problem with the release automation that needs to be fixed.
{ | ||
"name": "@openfeature/angular-sdk", | ||
"version": "0.0.17", | ||
"version": "0.0.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 I have created a release beep boop
0.0.10 (2025-09-30)
✨ New Features
🐛 Bug Fixes
🧹 Chore
📚 Documentation
This PR was generated with Release Please. See documentation.