Skip to content

feat: add caching for pipelines #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 23, 2023
Merged

feat: add caching for pipelines #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a88f86
feat: add npm caching
RealAnna Mar 23, 2023
4ccbc36
feat: add npm caching
RealAnna Mar 23, 2023
697c1bd
test pipeline cache
RealAnna Mar 23, 2023
ba2f06d
fix: review
RealAnna Mar 23, 2023
6ce13cd
fix: review
RealAnna Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
- uses: actions/setup-node@v3
with:
registry-url: 'https://registry.npmjs.org'
node-version: 16
cache: 'npm'

- name: Install
run: npm ci
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
cache: 'npm'

- name: Install
run: npm ci
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
with:
node-version: 16
registry-url: "https://registry.npmjs.org"
cache: 'npm'
- name: Build Packages
run: |
npm ci
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"homepage": "https://github.com/open-feature/js-sdk#readme",
"engines": {
"node": ">=14"
"node": ">=16"
},
"devDependencies": {
"@openfeature/flagd-provider": "~0.7.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@
"url": "https://github.com/open-feature/js-sdk/issues"
},
"homepage": "https://github.com/open-feature/js-sdk#readme",
"engines": {
"node": ">=16"
},
Comment on lines +47 to +49
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for others. Previously the server SDK was requiring node 14, but that's very dead. We are upgrading to 16 here but not considering it a breaking change since the version is so old (even 16 is partially EOL).

https://endoflife.date/nodejs

"devDependencies": {
"@openfeature/shared": "0.0.2"
}
Expand Down