Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flanksource as a member #16

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

moshloop
Copy link
Contributor

No description provided.

@scottrigby
Copy link
Member

This definitely needs to be resolved. It's come up several times in meetings but now that the website is up let's prioritize this #22

@scottrigby scottrigby removed the enhancement New feature or request label Jul 28, 2021
@scottrigby
Copy link
Member

@moshloop would you contribute to conversation about #22? I don't think this is correct as-is, unfortunately. I do think we need to prioritize having a clear way to list orgs that current working group members are part of, and/or from the interested parties document: https://github.com/gitops-working-group/gitops-working-group/blob/main/interested-parties.md

@scottrigby scottrigby added the question Further information is requested label Jul 28, 2021
@todaywasawesome
Copy link
Member

@moshloop I suggest making a separate PR to add flanksource as a member while we figure out how to resolve a "current" maintainers callout. We could get that added right away.

@todaywasawesome todaywasawesome self-requested a review July 28, 2021 18:58
Copy link
Member

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshloop For now, let's remove the featured-members.js so we can get you added right away and then figure out #22

@moshloop
Copy link
Contributor Author

@todaywasawesome I disagree, if anything we should remove founding members completely, and add them back in the form of a PR.

The charter is explicit in that this WG is a:

  1. Time-Bound (In which case Founding and Current are not relevant)
  2. Vendor-Neutral, By differentiating between "membership" levels by definition you are not neutral.

@scottrigby
Copy link
Member

@moshloop the order of operations here is up to you. This PR is about adding Flanksource, not fully resolving #22 which requires agreeing on a solution, so I believe scope creep in this PR is holding up adding your company. By contrast, see #26 which was easy to merge even before 22 is solved.

@moshloop moshloop mentioned this pull request Aug 15, 2021
5 tasks
@lloydchang
Copy link
Contributor

Relates to open-gitops/project#34 (comment)

@scottrigby
Copy link
Member

@moshloop circling back on this. Would you like to update this PR per review feedback, or would you rather close this PR? To reiterate #16 (comment) there is nothing blocking adding this company as a member – there has been unblocking maintainer feedback since July and August 2021.

As mentioned in our meetings, in Slack and GitHub, it will be exciting to see Flanksource – and all member orgs – listed on the website. Finishing this PR will help with that. We also need additional help with this for the other orgs, in #56.

Thanks in advance

Signed-off-by: Moshe Immerman <moshe@flanksource.com>
Signed-off-by: Moshe Immerman <moshe@flanksource.com>
@moshloop
Copy link
Contributor Author

@scottrigby I have added a founding and a current tag to members - what defines current can be addressed in the future
Screenshot 2022-01-20 at 15 45 45

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshloop this lgtm now 💯 Thanks for updating. I somehow didn't register that you had resolved the issue above 2 months ago.

@scottrigby scottrigby dismissed todaywasawesome’s stale review March 30, 2022 18:12

Dan's comment was resolved

@scottrigby scottrigby merged commit b3cebec into open-gitops:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants