Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path warnings in use declarations for beta and nightly #233

Closed
wants to merge 1 commit into from

Conversation

eyeplum
Copy link
Member

@eyeplum eyeplum commented Oct 10, 2018

This pull request fixes build warnings related to module paths in use declarations for beta and nightly toolchains.

@eyeplum
Copy link
Member Author

eyeplum commented Oct 10, 2018

Hmmm, looks like the crate:: notation is not supported by stable and 1.26.0.

@behnam
Copy link
Member

behnam commented Oct 10, 2018

Oh, I thought master is broken. Apparently it's not, but the builds here were failing because of the new code was based on the code before we allow warnings again.

So, let's just crate:: prefixes and all should be fine now. Right?

@behnam
Copy link
Member

behnam commented Oct 10, 2018

Uh, prev comment was for #227 .

Right, we can't actually do this here yet. Let's wait until we bump up min-rustc-version to what's beta right now.

Thanks for working on it, though, and sorry for my misleading comment. :(

@behnam behnam closed this Oct 10, 2018
@eyeplum
Copy link
Member Author

eyeplum commented Oct 10, 2018

No worries, it was fairly straight forward to work on and I've learnt something about Rust 2018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants