Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16720: Add Support for Salesforce SSL #16719

Merged
merged 7 commits into from
Jun 20, 2024
Merged

#16720: Add Support for Salesforce SSL #16719

merged 7 commits into from
Jun 20, 2024

Conversation

ayush-shah
Copy link
Member

Describe your changes:

Add Support for Salesforce SSL

I worked on implementing / allowing salesforce connection using ssl

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added documentation Improvements or additions to documentation UI UI specific issues Ingestion backend safe to test Add this label to run secure Github workflows on PRs labels Jun 19, 2024
@ayush-shah ayush-shah changed the title Minor: Add Support for Salesforce SSL #16720: Add Support for Salesforce SSL Jun 19, 2024
@ayush-shah ayush-shah linked an issue Jun 19, 2024 that may be closed by this pull request
Ingestion: Add Support for Salesforce SSL #16720
Closed
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.19% (35228/54037) 42.03% (13943/33177) 43.95% (4322/9835)

sushi30
sushi30 reviewed Jun 20, 2024
View reviewed changes
ingestion/src/metadata/utils/ssl_manager.py
@@ -147,7 +170,22 @@ def _(self, connection):


@singledispatch
def check_ssl_and_init(_):
def check_ssl_and_init(_) -> None:
return None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to raise NotImplementedError for the base case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of doing a whole cleanup, so that we need to initialize and modify things at single place
It will take place as part of this #15913

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jun 20, 2024

Passing run #34449 ↗︎

0 541 421 0 Flakiness 0

Details:

Add Tests For ClassConverter
Project: openmetadata Commit: 85d932784f
Status: Passed Duration: 23:17 💡
Started: Jun 20, 2024 5:10 AM Ended: Jun 20, 2024 6:33 AM

Review all test suite changes for PR #16719 ↗︎

@ayush-shah ayush-shah merged commit c9a017d into main Jun 20, 2024
36 of 37 checks passed
@ayush-shah ayush-shah deleted the salesforce-ssl branch June 20, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@sushi30 sushi30 sushi30 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingestion: Add Support for Salesforce SSL
3 participants
@ayush-shah @harshach @sushi30