-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Fix the issue that the click version is locked at 7.x #127
Conversation
Suggest renaming |
The name |
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 32.58% 32.77% +0.19%
==========================================
Files 21 22 +1
Lines 1593 1620 +27
Branches 363 371 +8
==========================================
+ Hits 519 531 +12
- Misses 1032 1045 +13
- Partials 42 44 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Done. I added this step to the CI:
|
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix the issue that the click version is locked at 7.x, fixes #123
In addition, add .vscode into .gitignore make vscode user happy.
Modification
BC-breaking (Optional)
No
Use cases (Optional)
No
Checklist