Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-488] Add new configuration files for SoftTeacher algorithm in mmdetection. #10856

Open
wants to merge 5 commits into
base: dev-3.x
Choose a base branch
from

Conversation

Shengshenlan
Copy link

@Shengshenlan Shengshenlan commented Aug 30, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

To finish the task in CodeCamp2023

Modification

Add new configuration files for SoftTeacher

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hhaAndroid
Copy link
Collaborator

@Shengshenlan 这个pr 是完成状态是吗?

@Shengshenlan
Copy link
Author

mmdet/configs/base/datasets/semi_coco_detection.py import部分

我用如下写法,会有错误

# Copyright (c) OpenMMLab. All rights reserved.
from mmengine.config import read_base

with read_base():
    from mmdet.datasets.transforms.transforms import *

from mmcv import RandomResize
from mmcv.transforms import LoadImageFromFile
from mmengine.dataset import ConcatDataset
from mmengine.dataset.sampler import DefaultSampler

from mmdet.datasets import (AspectRatioBatchSampler, CocoDataset,
                            GroupMultiSourceSampler)
from mmdet.datasets.transforms.augment_wrappers import RandAugment
from mmdet.evaluation import CocoMetric

错误如下

Traceback (most recent call last):
  File "tools/train.py", line 133, in <module>
    main()
  File "tools/train.py", line 70, in main
    cfg = Config.fromfile(args.config)
  File "/opt/anaconda3/envs/pytorch/lib/python3.7/site-packages/mmengine/config/config.py", line 489, in fromfile
    raise e
  File "/opt/anaconda3/envs/pytorch/lib/python3.7/site-packages/mmengine/config/config.py", line 487, in fromfile
    cfg_dict, imported_names = Config._parse_lazy_import(filename)
  File "/opt/anaconda3/envs/pytorch/lib/python3.7/site-packages/mmengine/config/config.py", line 1075, in _parse_lazy_import
    module_path)
  File "/opt/anaconda3/envs/pytorch/lib/python3.7/site-packages/mmengine/config/config.py", line 1075, in _parse_lazy_import
    module_path)
  File "/opt/anaconda3/envs/pytorch/lib/python3.7/site-packages/mmengine/config/config.py", line 1075, in _parse_lazy_import
    module_path)
  File "/opt/anaconda3/envs/pytorch/lib/python3.7/site-packages/mmengine/config/config.py", line 1104, in _parse_lazy_import
    global_dict)
  File "/root/data/mmdetection/mmdet/datasets/transforms/transforms.py", line 40, in <module>
    Number = Union[int, float]
TypeError: 'LazyObject' object is not subscriptable

如果不使用 import * 的写法,把它写开,就会有 isort和yapf 冲突的问题

下面是yapf缩进的格式

# Copyright (c) OpenMMLab. All rights reserved.
from mmcv import RandomResize
from mmcv.transforms import LoadImageFromFile
from mmengine.config import read_base
from mmengine.dataset import ConcatDataset
from mmengine.dataset.sampler import DefaultSampler

from mmdet.datasets import (AspectRatioBatchSampler, CocoDataset,
                            GroupMultiSourceSampler)
from mmdet.datasets.transforms import (
    AutoContrast, Brightness, Color, ColorTransform, Contrast, Equalize,
    FilterAnnotations, LoadAnnotations, LoadEmptyAnnotations, MultiBranch,
    PackDetInputs, Posterize, RandomErasing, RandomFlip, RandomOrder, Resize,
    Rotate, Sharpness, ShearX, ShearY, Solarize, SolarizeAdd, TranslateX,
    TranslateY)
from mmdet.datasets.transforms.augment_wrappers import RandAugment
from mmdet.evaluation import CocoMetric

下面是isort的格式

# Copyright (c) OpenMMLab. All rights reserved.
from mmcv import RandomResize
from mmcv.transforms import LoadImageFromFile
from mmengine.config import read_base
from mmengine.dataset import ConcatDataset
from mmengine.dataset.sampler import DefaultSampler

from mmdet.datasets import (AspectRatioBatchSampler, CocoDataset,
                            GroupMultiSourceSampler)
from mmdet.datasets.transforms import (AutoContrast, Brightness, Color,
                                       ColorTransform, Contrast, Equalize,
                                       FilterAnnotations, LoadAnnotations,
                                       LoadEmptyAnnotations, MultiBranch,
                                       PackDetInputs, Posterize, RandomErasing,
                                       RandomFlip, RandomOrder, Resize, Rotate,
                                       Sharpness, ShearX, ShearY, Solarize,
                                       SolarizeAdd, TranslateX, TranslateY)
from mmdet.datasets.transforms.augment_wrappers import RandAugment
from mmdet.evaluation import CocoMetric

究竟该咋解决啊,都试了很多次。

@hhaAndroid
Copy link
Collaborator

@Shengshenlan OK.let me take a look.

@Shengshenlan
Copy link
Author

@Shengshenlan OK.let me take a look.

Hello, have you checked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants