Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Enhance the error catching in registry #1010

Merged

Conversation

HAOCHENYE
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The original implementation will catch the error raised in the registry process, which leads to an error like xxx not found in yyy registry and hide the real error like "ModuleNotFoundError: No module named pycocotools" caused by third party.

This PR will enhance error-catching logic. If the error is raised in registering process, it will be directly raised rather than watched by us and only throw a warning.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@ad33a7d). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 26670ae differs from pull request most recent head 826c082. Consider uploading reports for the commit 826c082 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage        ?   76.60%           
=======================================
  Files           ?      139           
  Lines           ?    11030           
  Branches        ?     2207           
=======================================
  Hits            ?     8449           
  Misses          ?     2214           
  Partials        ?      367           
Flag Coverage Δ
unittests 76.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhouzaida zhouzaida merged commit 26a7a92 into open-mmlab:main Mar 29, 2023
xiexinch added a commit to open-mmlab/mmsegmentation that referenced this pull request Apr 3, 2023
## Motivation

If the module does not actually exist, setting locations will report an
error.

open-mmlab/mmengine#1010

## Modification

mmseg/registry/registry.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants