Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove locations of not exists modules in the registry #2829

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

xiexinch
Copy link
Collaborator

@xiexinch xiexinch commented Apr 3, 2023

Motivation

If the module does not actually exist, setting locations will report an error.

open-mmlab/mmengine#1010

Modification

mmseg/registry/registry.py

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0e6f0e6) 83.70% compared to head (1bbb17e) 83.70%.

❗ Current head 1bbb17e differs from pull request most recent head 13b631e. Consider uploading reports for the commit 13b631e to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2829   +/-   ##
========================================
  Coverage    83.70%   83.70%           
========================================
  Files          156      156           
  Lines         9355     9355           
  Branches      1373     1373           
========================================
  Hits          7831     7831           
  Misses        1279     1279           
  Partials       245      245           
Flag Coverage Δ
unittests 83.70% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/registry/registry.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xiexinch xiexinch merged commit 4dc4ed9 into open-mmlab:dev-1.x Apr 3, 2023
@xiexinch xiexinch deleted the fix_registry branch April 3, 2023 09:29
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
…lab#2829)

## Motivation

If the module does not actually exist, setting locations will report an
error.

open-mmlab/mmengine#1010

## Modification

mmseg/registry/registry.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants