Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp #1536] Add MattingMSE #71

Merged
merged 14 commits into from
Jan 15, 2023
Merged

Conversation

xuan07472
Copy link
Contributor

@xuan07472 xuan07472 commented Dec 30, 2022

Motivation

Add MattingMSE of MMEditing to MMEval and complete the adaptation.

Modification

Add MattingMSE of MMEditing to MMEval
The PR link using mmeval.MattingMSE in mmediting:open-mmlab/mmagic#1591 (comment)

@ice-tong ice-tong changed the title CodeCamp #MMEditing-1536 [CodeCamp #1536] Add MattingMSE Dec 30, 2022
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
@ice-tong
Copy link
Collaborator

ice-tong commented Jan 6, 2023

Please add the MattingMSE API reference in docs/zh_cn/api/metrics.rst and docs/en/api/metrics.rst.

@ice-tong
Copy link
Collaborator

ice-tong commented Jan 6, 2023

Please add the PR link using mmeval.MattingMSE in mmediting~

Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 5 comments

mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
mmeval/metrics/matting_mse.py Outdated Show resolved Hide resolved
xuan07472 and others added 2 commits January 9, 2023 13:49
Modify format statement

Co-authored-by: yancong <32220263+ice-tong@users.noreply.github.com>
@ice-tong
Copy link
Collaborator

Please @zhouzaida have a look~

@zhouzaida zhouzaida merged commit 0e8fce2 into open-mmlab:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants