Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] wgangp config error #100

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

zeng-hello-world
Copy link
Contributor

No description provided.

@nbei nbei requested a review from plyfager September 1, 2021 06:42
Copy link
Collaborator

@plyfager plyfager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run pre-commit run --all-files to fix lint.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #100 (a10deb9) into master (931b3ea) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   76.01%   75.98%   -0.03%     
==========================================
  Files         118      118              
  Lines        8092     8092              
  Branches     1520     1520              
==========================================
- Hits         6151     6149       -2     
- Misses       1550     1551       +1     
- Partials      391      392       +1     
Flag Coverage Δ
unittests 75.98% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/datasets/pipelines/crop.py 95.06% <100.00%> (ø)
mmgen/datasets/unconditional_image_dataset.py 88.57% <100.00%> (ø)
mmgen/models/gans/base_gan.py 68.13% <100.00%> (ø)
mmgen/models/gans/singan.py 74.03% <100.00%> (ø)
mmgen/ops/conv2d_gradfix.py 14.95% <100.00%> (ø)
mmgen/models/architectures/stylegan/mspie.py 90.59% <0.00%> (-1.00%) ⬇️
...chitectures/stylegan/generator_discriminator_v1.py 89.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931b3ea...a10deb9. Read the comment docs.

@nbei
Copy link
Collaborator

nbei commented Sep 3, 2021

Hi @zeyu-hello, you may use the pre-commit hook by the following commands:

cd mmgen
pip install -U pre-commit
pre-commit install

Then, when you commit changes, the pre-commit hook will automatically check your linting error.

@zeng-hello-world
Copy link
Contributor Author

@nbei On my PC, all passed:

pre-commit run --all-files
flake8...................................................................Passed
seed isort known_third_party.............................................Passed
isort....................................................................Passed
yapf.....................................................................Passed
Trim Trailing Whitespace.................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Fix requirements.txt.....................................................Passed
Fix double quoted strings................................................Passed
Check for merge conflicts................................................Passed
Fix python encoding pragma...............................................Passed
Mixed line ending........................................................Passed
docformatter.............................................................Passe

@zengyh1900 zengyh1900 added this to the 0.8.0 milestone Oct 12, 2022
@zengyh1900 zengyh1900 added kind/bug something isn't working awaiting response priority/P0 highest priority labels Oct 12, 2022
@zengyh1900
Copy link
Collaborator

Please help to improve this pull request so that it can be merged @plyfager

@plyfager
Copy link
Collaborator

plyfager commented Oct 13, 2022

Thank you for your contribution. I'll further modify this PR and make it merged.

@plyfager plyfager modified the milestones: 0.8.0, Backlog Oct 13, 2022
@plyfager plyfager added status/WIP work in progress normally and removed awaiting response labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug something isn't working priority/P0 highest priority status/WIP work in progress normally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants