Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Jul 1, 2016

For user defined MPI_Op types the o_name field is never set. Some components use this field for verbose output, and leaving it undefined makes the output difficult to review. So this commit makes sure that it gets initialized in all paths.

open-mpi/ompi#1833

@jjhursey
Copy link
Member Author

jjhursey commented Jul 1, 2016

bot:label:Code-cleanup-low-priority
bot:milestone:v2.0.1

@ibm-ompi
Copy link

ibm-ompi commented Jul 1, 2016

Build Failed with GNU compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/c84e7946a8ca619afdf1a7faae20aabb

@ibm-ompi
Copy link

ibm-ompi commented Jul 1, 2016

Build Failed with XL compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/6d6eb8de75cf06ec6cb15129d7b8eeba

@jjhursey
Copy link
Member Author

jjhursey commented Jul 1, 2016

bot:ibm:retest

@ibm-ompi
Copy link

ibm-ompi commented Jul 1, 2016

Build Failed with GNU compiler! Please review the log, and get in touch if you have questions.

Gist: https://gist.github.com/6f633992afd9bb64cdda25894c9f1765

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1829/ for details.

@jjhursey
Copy link
Member Author

jjhursey commented Jul 5, 2016

bot:ibm:retest

@jjhursey
Copy link
Member Author

bot:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1846/ for details.

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1940/ for details.

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1943/ for details.

@jjhursey
Copy link
Member Author

bot:assign: @jsquyres
@jsquyres Can you review? I thought you already did, and it's a small change.

The mellanox failure is unrelated.
bot:retest

@jsquyres
Copy link
Member

👍
bot:retest

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1948/ for details.

@jsquyres
Copy link
Member

Mellanox Jenkins failure is unrelated. Per the call today, @artpol84 is investigating.

@jsquyres jsquyres merged commit 310aaef into open-mpi:v2.x Jul 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants