Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

v2.x mpi ext updates #345

Merged
merged 5 commits into from
Jun 30, 2015
Merged

v2.x mpi ext updates #345

merged 5 commits into from
Jun 30, 2015

Conversation

jsquyres
Copy link
Member

These are pulled straight from master. I did not include @rolfv's new cuda MPI extension; that can be a separate PR.

@ggouaillardet please review

jsquyres and others added 4 commits June 29, 2015 09:41
@jsquyres
MPI extensions: build extensions by default
6630f88 
* affinity: will build unless disabled.
* cr: will build if FT is enabled, unless it is disabled.  It will
  also complain/abort if you --with-mpi-ext=cr, but FT is disabled.
* example: will only build if --with-mpi-ext=example (and .ompi_ignore
  is removed)

(cherry picked from commit fca193d)
@jsquyres
Remove manpages when doing distclean in the OMPI extensions area
5f77fef 
(cherry picked from commit open-mpi/ompi@2fa8167)
@ggouaillardet @jsquyres
mpiext/affinity: #if OPAL_HAVE_HWLOC most parts of the code
8a38b7a 
that allow this extension to compile if configure'd with --without-hwloc

(cherry picked from commit 6994d74)
@jsquyres
mpiext_affinity_str.c: minor stylistic updates
64b9214 
No real functional changes:

* Reduce #if's a little -- have a single "no hwloc" and "hwloc"
  section.
* Make a common subroutine (no_hwloc_support()) for when we don't have
  any hwloc support

(cherry picked from commit f6882a8)
@jsquyres jsquyres added this to the v2.0.0 milestone Jun 29, 2015
@mellanox-github
Copy link

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/job/gh-ompi-release-v1.8-pr/369/

@lanl-ompi
Copy link
Contributor

Test FAILed.

@jsquyres
Copy link
Member Author

@hppritcha This looks like a false failure on the distcheck jenkins:

  CCLD     libmca_common_verbs.la
gcc: /usr/lib64/libosmcomp.so: No such file or directory
make[3]: *** [libmca_common_verbs.la] Error 1
make[3]: Leaving directory `/global/u2/h/hpp/jenkins_hopper/workspace/ompi_v2.x_pr_distcheck2/openmpi-gitclone/_build/opal/mca/common/verbs'

Can you confirm?

@jsquyres
Copy link
Member Author

@hppritcha BTW, why do all the LANL CI checks say "No test results found"?

@hppritcha
Copy link
Member

This is a false failure on the jenkins distcheck.

The no test results found is a default from the ghprb - trying to figure out how to turn this off. There's a lot of churn in the options for the ghprb lately.

@hppritcha
Copy link
Member

bot:retest

@lanl-ompi
Copy link
Contributor

Test FAILed.

@hppritcha
Copy link
Member

okay try again - consequence of temporarily moving distcheck to hopper.

bot:retest

@ggouaillardet
Copy link
Contributor

@jsquyres you need to cherry-pick open-mpi/ompi@a4cc83f as well (incomplete prototype)
(there might be a conflict in the copyright due to the massive whitespace removal ...)

:bot🏷️pushed-back

@jsquyres
Copy link
Member Author

@ggouaillardet Got it; thanks.

@mellanox-github
Copy link

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/375/

@ggouaillardet
Copy link
Contributor

@rhc54 suggested off list that the affinity extension should not be built at all without helicopter support
(e.g. update configury)

any thought ?

@rhc54
Copy link

rhc54 commented Jun 30, 2015

my whirlybird actually suggests that it is better to build as you have done - that way, a user's code can just call the extension without worrying that it might not be there. It just can't tell them anything useful as we cannot bind without helicopter

@ggouaillardet
Copy link
Contributor

+1
btw, iPad thinks hwloc is an helicopter :-)

@hppritcha
Copy link
Member

sanity check since IU jenkins ghprb plugin was upgraded to 1.24.4 and there were errors processing the ompi-release webhooks on the server.

bot:retest

@jsquyres
Copy link
Member Author

I'm assuming @ggouaillardet's "+1" was meant to be a 👍

jsquyres added a commit that referenced this pull request Jun 30, 2015
@jsquyres
Merge pull request #345 from jsquyres/pr/v2.x-mpi-ext-updates
ac324b4 
v2.x mpi ext updates
@jsquyres jsquyres merged commit ac324b4 into open-mpi:v2.x Jun 30, 2015
@jsquyres jsquyres deleted the pr/v2.x-mpi-ext-updates branch June 30, 2015 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@ggouaillardet ggouaillardet

Labels

enhancement reviewed RM-Approved

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jsquyres @mellanox-github @lanl-ompi @hppritcha @ggouaillardet @rhc54 @ompiteam-bot