fs/gpfs: fail common symbols check

[naughtont3]

Check for common symbols is failing during make install due to ompi/mca/fs/gpfs pulling in gpfs_hint_* symbols.

What version of Open MPI are you using?

master at 0276679

Describe how Open MPI was installed (e.g., from a source/distribution tarball, from a git clone, from an operating system distribution package, etc.)

Building from git clone on IBM (Summit).

If you are building/installing from a git clone, please copy-n-paste the output from git submodule status.

[naughton@login4.summit openmpi-br-master]$ git submodule status
 38433c0f5fae0b761bd20e7b928c77f3ff2e76dc opal/mca/hwloc/hwloc2/hwloc (hwloc-2.1.0rc2-33-g38433c0)
 a9ab80650de09dacc1e5c37deae682fbf34fcd24 opal/mca/pmix/pmix4x/openpmix (v1.1.3-2197-ga9ab806)
 fc30acbf0ff0d0557bac91ac7a8019d9723ff5c8 prrte (dev-30308-gfc30acb)
[naughton@login4.summit openmpi-br-master]$ git log --oneline | head -1
0276679 Merge pull request #7418 from rhc54/topic/up
[naughton@login4.summit openmpi-br-master]$ git br
* master

Please describe the system on which you are running

• Operating system/version:
• Computer hardware:
• Network type:

---

Details of the problem

During the install phase the make install-exec-hook fails when running common symbol check.

[naughton@login4.summit openmpi-br-master]$ make install-exec-hook
    WARNING!  Common symbols found:
      fs_gpfs_file_set_info.o: 0000000000000030 C gpfs_hint_AccessRange
      fs_gpfs_file_set_info.o: 0000000000000020 C gpfs_hint_ByteRange
      fs_gpfs_file_set_info.o: 0000000000000018 C gpfs_hint_CancelHints
      fs_gpfs_file_set_info.o: 0000000000000018 C gpfs_hint_ClearFileCache
      fs_gpfs_file_set_info.o: 0000000000000028 C gpfs_hint_FreeRange
      fs_gpfs_file_set_info.o: 0000000000000028 C gpfs_hint_GetAppendOnly
      fs_gpfs_file_set_info.o: 0000000000000028 C gpfs_hint_GetExpTime
      fs_gpfs_file_set_info.o: 0000000000000418 C gpfs_hint_GetFilesetName
      fs_gpfs_file_set_info.o: 0000000000000028 C gpfs_hint_GetImmutable
      fs_gpfs_file_set_info.o: 0000000000000030 C gpfs_hint_GetReplication
    [...]
    skipping remaining symbols. To see all symbols, run:
      ../../../../source/openmpi-br-master/config/find_common_syms --top_builddir=. --top_srcdir=../../.
./../source/openmpi-br-master --objext=o
    make: [install-exec-hook] Error 1 (ignored)
    [naughton@login4.summit openmpi-br-master]$

The work around was to drop a whitelist file into the offending directory.

 [naughton@login4.summit openmpi-br-master]$ cat ompi/mca/fs/gpfs/common_sym_whitelist.txt
# Ignore symbols in fs/gpfs that are problematic for running
# the 'make install-exec-hook' on GPFS system (ornl)
gpfs_hint_AccessRange
gpfs_hint_ByteRange
gpfs_hint_CancelHints
gpfs_hint_ClearFileCache
gpfs_hint_FreeRange
gpfs_hint_GetAppendOnly
gpfs_hint_GetExpTime
gpfs_hint_GetFilesetName
gpfs_hint_GetImmutable
gpfs_hint_GetReplication
gpfs_hint_GetSnapshotName
gpfs_hint_GetStoragePool
gpfs_hint_MultipleAccessRange
gpfs_hint_RangeArray
gpfs_hint_RestripeData
gpfs_hint_RestripeRange
gpfs_hint_SetAppendOnly
gpfs_hint_SetExpTime
gpfs_hint_SetImmutable
gpfs_hint_SetReplication
gpfs_hint_SetStoragePool

[naughtont3]

For my notes, here was my build env info...

[naughton@login4.summit openmpi-br-master]$ module use /sw/summit/ums/ompix/DEVELOP/gcc/8.1.1/modules 
[naughton@login4.summit openmpi-br-master]$ module list

Currently Loaded Modules:
  1) hsi/5.0.2.p5    3) DefApps     5) cuda/10.1.168
  2) lsf-tools/2.0   4) gcc/8.1.1   6) ucx/1.6.1

[edgargabriel]

@naughtont3 we'll have a look at it.

[edgargabriel]

@naughtont3 pr #7476 should fix the issue, could you maybe give it a try, and let us know if you see other issues?

[naughtont3]

@edgargabriel looks good. tested master ceb5212 and make install had no problem on summit.