-
Notifications
You must be signed in to change notification settings - Fork 908
glob.h check fixed, otherwise it always fails #10368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
bot:aws:retest |
Hmm..
|
I have no idea what this is or where the issue stems from? I mean, it is probably me in both cases but I can't recall that I ever edited this file manually? |
Yeah...I don't really understand why this commit is complaining. It would make some sense if you are the author 🤷♂️. not sure what to do here, other PR's from this morning passed. |
Someone broke "make dist" on master; all PRs are going to fail until the .mailmap has been updated. I'm not sure why it didn't trigger on the commit of the ROCm patches (which looks like the breaking commit), but here we are. |
Yup, seeing other PR's fail now. I think you can add your new user/email to the mailmap here: https://github.com/open-mpi/ompi/blob/main/.mailmap @edgargabriel |
I can do that, but I am not sure I understand. I made probably a dozen commits from my outlook email address that is not listed in that file as well. Could the issue be that the two email addresses listed in that file are not associated with my github account anymore? ( I closed them and removed them when I left UH) |
Never mind, I see how I broke things :-( PR #10372 seems to be fixing it. It looks like on one of the machines that I made commits from for the rocm patch the git setup was not entirely correct, and I missed that. Sorry! |
Thanks! bot:aws:retest |
Signed-off-by: Austen Lauria awlauria@us.ibm.com