Skip to content

glob.h check fixed, otherwise it always fails #10368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022

Conversation

awlauria
Copy link
Contributor

Signed-off-by: Austen Lauria awlauria@us.ibm.com

Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
@awlauria
Copy link
Contributor Author

bot:aws:retest

@awlauria
Copy link
Contributor Author

Hmm..

*** WARNING: The following people had the same email address:
***   Edgar, Edgar Gabriel

*******************************************************************************
*** YOU SHOULD EDIT THE .mailmap FILE TO RESOLVE THESE WARNINGS!
*******************************************************************************
New AUTHORS file written.
make[2]: *** [Makefile:1941: AUTHORS] Error 1
make[2]: Leaving directory '/home/ubuntu/workspace/open-mpi.build.distcheck/src'
make[1]: *** [Makefile:1592: distdir] Error 2
make[1]: Leaving directory '/home/ubuntu/workspace/open-mpi.build.distcheck/src'
make: *** [Makefile:1696: dist] Error 2
Build step 'Execute shell' marked build as failure
Finished: FAILURE

@edgargabriel ?

@edgargabriel
Copy link
Member

I have no idea what this is or where the issue stems from? I mean, it is probably me in both cases but I can't recall that I ever edited this file manually?

@awlauria
Copy link
Contributor Author

awlauria commented May 11, 2022

Yeah...I don't really understand why this commit is complaining. It would make some sense if you are the author 🤷‍♂️.

not sure what to do here, other PR's from this morning passed.

@bwbarrett
Copy link
Member

Someone broke "make dist" on master; all PRs are going to fail until the .mailmap has been updated. I'm not sure why it didn't trigger on the commit of the ROCm patches (which looks like the breaking commit), but here we are.

@awlauria
Copy link
Contributor Author

Yup, seeing other PR's fail now.

I think you can add your new user/email to the mailmap here: https://github.com/open-mpi/ompi/blob/main/.mailmap @edgargabriel

@edgargabriel
Copy link
Member

I can do that, but I am not sure I understand. I made probably a dozen commits from my outlook email address that is not listed in that file as well. Could the issue be that the two email addresses listed in that file are not associated with my github account anymore? ( I closed them and removed them when I left UH)

@edgargabriel
Copy link
Member

Never mind, I see how I broke things :-( PR #10372 seems to be fixing it. It looks like on one of the machines that I made commits from for the rocm patch the git setup was not entirely correct, and I missed that. Sorry!

@awlauria
Copy link
Contributor Author

Thanks!

bot:aws:retest

@awlauria awlauria merged commit fa08eac into open-mpi:main May 12, 2022
@awlauria awlauria deleted the fix_psm2_configure branch May 12, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants