OFI: call fi_getname twice #10620
Merged
OFI: call fi_getname twice #10620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you need to duplicate the code or is there a place for shared OFI utilities? |
|
@tschuett good point. I'll refactor into ofi common. |
hppritcha
force-pushed
the
remove_fi_name_max
branch
2 times, most recently
from
8f95d28 to
53b6bd4
Compare
|
@wckzhang could you review this PR when you have a chance? |
tschuett
reviewed
Aug 2, 2022
opal/mca/common/ofi/common_ofi.c
Outdated
| /** | ||
| * Obtain EP endpoint name | ||
| * | ||
| * This function obtained the EP endpoint name and length for the |
There was a problem hiding this comment.
It is not good style to start comments with the function name or this function. The obtained makes me wonder whether I should call the function all. It seems to be finished already. I would prefer obtains.
hppritcha
force-pushed
the
remove_fi_name_max
branch
from
53b6bd4 to
664e015
Compare
wckzhang
approved these changes
Aug 4, 2022
opal/mca/btl/ofi/btl_ofi_component.c
Outdated
| @@ -663,6 +663,10 @@ static int mca_btl_ofi_init_device(struct fi_info *info) | |||
| } | |||
| free(module); | |||
|
|
|||
| if (ep_name) { | |||
There was a problem hiding this comment.
Can you make the format consistent ie.
if (NULL != ep_name)
first to get the length of the buffer needed for the endpoint name, then a second time with the properly sized buffer to receive the endpoint name. The FI_NAME_MAX enum was not supposed to have been exposed to libfabric consumers. See ofiwg/libfabric#7898. Related to open-mpi#10617 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
remove_fi_name_max
branch
from
664e015 to
1a00a89
Compare
wckzhang
approved these changes
Aug 4, 2022
|
I'm going to pull down this patch and test it with EFA |
|
that would be great! thanks for testing. |
|
Seems to work as expected, gets the length and successfully runs with EFA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first to get the length of the buffer needed for the endpoint name,
then a second time with the properly sized buffer to receive the
endpoint name.
The FI_NAME_MAX enum was not supposed to have been exposed to libfabric consumers.
See ofiwg/libfabric#7898.
Related to #10617
Signed-off-by: Howard Pritchard howardp@lanl.gov