Fixup: osc/ucx: implement rput and rget using ucp_worker_flush_nb #10642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit eee891f.
Fallback to the old method of acquiring a request from an atomic operation is preserved. Some networks might provide better performance if the request-based operations do not rely on atomic operations. Some minor fixes to opal_common_ucx_winfo_flush included in this commit. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
janjust
approved these changes
Aug 9, 2022
|
bot:retest |
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@janjust discovered that there was a problem in #10536 merged into
mainand that that problem was not present in the v5.0.x backport (#10554). I don't remember what I did there but apparently I must have bungled the backport.In particular, an erroneous return was left in
main(https://github.com/open-mpi/ompi/pull/10536/files#diff-881c0a8eb55eaa0334196bf23fe14f90225450cd3e1a2a35b977ce4d047d68b0R1121-R1123) but not in 5.0.x (https://github.com/open-mpi/ompi/pull/10554/files?diff=unified&w=0#diff-881c0a8eb55eaa0334196bf23fe14f90225450cd3e1a2a35b977ce4d047d68b0R1146-R1163).The proposal to fix this is to revert the original commit and replace it with a fixed version. This PR combines both commits. Once passed, I will open a PR to 5.0.x that reverts the original cherry-picked commit and cherry-picks the replacement commit from this PR. There should be no difference between the two in 5.0.x and it's only meant to keep
mainand 5.0.x in sync. Please let me know if there are any concerns about this approach.