build: Drop support for config-time componets #10769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Sep 6, 2022
bosilca
approved these changes
Sep 7, 2022
bwbarrett
force-pushed
the
cleanup/mca-no-config-time-components
branch
from
015b3b9 to
2c7cf7c
Compare
jsquyres
approved these changes
Sep 9, 2022
bwbarrett
force-pushed
the
cleanup/mca-no-config-time-components
branch
from
2c7cf7c to
f9e6d6f
Compare
Drop support for both adding components at configure time (ie, after autogen has run) and components that have a stand-alone configure script. The first change greatly simplifies reasoning about variable names in the MCA configure code, since the component name will never be a shell variable with this change. Note that there was already one place where we would have mis-handled such a component, in setting LDFLAGS for the wrapper compilers. The second is dead code after the first, as no component currently built in the OMPI tree uses an external configure script directly (note that config macros that call a third-party configure script, like the io/romio component, are still fine). Organizations can still build tarballs with added components after this change, they just must run autogen to add the components to the list of available component. And developers are also free to add run-time components that are built outside of the OMPI build (generally by building OMPI with the --with-devel-headers configure option). Signed-off-by: Brian Barrett <bbarrett@amazon.com>
bwbarrett
force-pushed
the
cleanup/mca-no-config-time-components
branch
from
f9e6d6f to
6d06552
Compare
bwbarrett
changed the title
|
Last update was to fix a spelling error in the commit title. No other changes. Intend to commit when CI completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for both dropping in components to a tarball (without re-running autogen) and for using full configure scripts (which, practically speaking, was required for the first capability). We had accidentally broken both a couple months ago, and don't have any tests for it, so just remove.