Fix/avoid intrinsics collisions #10872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
Many compilers (tested with gcc and clang) use the memcpy and memmove keywords as intrinsics functions. They also lack a proper syntactic matching, and this prevents the use of any intrincs names as members of structures. Use a different name for the 2 members of the accelerator framework that handles memory copies and moves. Fixes open-mpi#10869. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
wckzhang
approved these changes
Sep 29, 2022
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memcpy and memove (among others intrinsics) cannot be used a members of structs.