Fix uninitialized variable in mca_coll_base_alltoallv_intra_basic_inplace: Coverity CID 1498685 #11150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwootton
changed the title
|
Wait a bit before reviewing. I'm going thru a list of Coverity reports sequentially and just noticed the same problem with coll_base_alltoall.c so will fix this in this pull request as well. |
|
coll_base_alltoall.c updated too, so now ready for review |
|
This error message is mostly for collective developers. Thus, knowing the source file and line number seem to be redundant with the newly added function that fails. |
…all. Coverity CID 1498685 Fix review comment. Signed-off-by: David Wootton <dwootton@us.ibm.com>
|
Removed function name from message. |
bosilca
approved these changes
Dec 6, 2022
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Coverity static analysis scan reported an uninitialized variable line in mca_coll_base_alltoallv_intra_basic_inplace.
This variable was intended to be set to the line number of a failing function call so that line number could be reported in an error message.
The fix sets line before branching to the exit point for each failing function call. Since line numbers may shift over time, I also added the function name to the error message.
Signed-off-by: David Wootton dwootton@us.ibm.com