Properly initialize mca_rcache_base_module_t members #12248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
approved these changes
Jan 19, 2024
devreal
force-pushed
the
rcache_base_lock_init
branch
from
cc03173 to
2e570a8
Compare
|
I added the destructor calls and removed the warning fixes. I will move them into a separate PR. |
bosilca
reviewed
Jan 19, 2024
There was a problem hiding this comment.
I don't see a valid reason to make to an object because:
- You don't use the regcache module as a reference counted object;
- No other framework is using the modules as derived-objects.
I would create a base_init function and let the different components call it directly.
devreal
force-pushed
the
rcache_base_lock_init
branch
2 times, most recently
from
86dcd02 to
5f4b211
Compare
|
@bosilca Makes sense. I made them inline functions but am happy to put them into |
|
It's a |
All but the udreg rcache module did not properly initialize the `lock` member in the mca_rcache_base_module_t parent, which triggers an assert on Mac OSX when trying to take that lock. Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>
devreal
force-pushed
the
rcache_base_lock_init
branch
from
5f4b211 to
f81fc3e
Compare
bosilca
approved these changes
Jan 22, 2024
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All but the udreg rcache module did not properly initialize the
lockmember in themca_rcache_base_module_tparent, which triggers an assert on Mac OSX when trying to take that lock.Also squashes some format string warnings (separate commit) in the gpusm rcache module. Clang-14 on Mac OSX complains about a mismatch between
void*andchar*.