Topic/hetero spawn #1385
Merged
Topic/hetero spawn #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggouaillardet
force-pushed
the
topic/hetero_spawn
branch
from
9fb4bba to
93a0e38
Compare
| * and OPAL_PMIX_HOSTNAME, and we can live withot them, so initialize | ||
| * these values here in case they are not retrieved */ | ||
| proc->super.proc_flags = OPAL_PROC_NON_LOCAL; | ||
| proc->super.proc_hostname = NULL; |
There was a problem hiding this comment.
FWIW: ompi_proc_complete_init_single already initializes these fields to these values, so this isn't really necessary. The only time they won't be initialized is when you call that function with your own process name, and that cannot happen here as we are only looping over processes we previously didn't know about.
There was a problem hiding this comment.
Thanks !
I will update and commit this on Monday
ggouaillardet
force-pushed
the
topic/hetero_spawn
branch
from
93a0e38 to
dcce040
Compare
and accept a proc from a different job
also remove code duplication by using ompi_proc_complete_init_single() Thanks Siegmar Gross for reporting this issue, and Ralph for the guidance.
ggouaillardet
force-pushed
the
topic/hetero_spawn
branch
from
dcce040 to
308bbcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.