Skip to content

v2.0.x: asm/ppc: Fix a regression in powerpc atomics #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2017
Merged

v2.0.x: asm/ppc: Fix a regression in powerpc atomics #2708

merged 1 commit into from
Jan 12, 2017

Conversation

nysal
Copy link
Member

@nysal nysal commented Jan 11, 2017

Add a missing constraint to the input operand list.
This fixes a regression caused by d4be138.
Thanks to Orion Poplawski for reporting the issue.

Refs #2610

Signed-off-by: Nysal Jan K.A jnysal@in.ibm.com

Add a missing constraint to the input operand list.
This fixes a regression caused by d4be138.
Thanks to Orion Poplawski for reporting the issue.

Refs #2610

Signed-off-by: Nysal Jan K.A <jnysal@in.ibm.com>
@nysal nysal added this to the v2.0.2 milestone Jan 11, 2017
@nysal nysal self-assigned this Jan 11, 2017
@nysal nysal requested a review from hjelmn January 11, 2017 16:17
@hjelmn
Copy link
Member

hjelmn commented Jan 11, 2017

It would have there same effect to change the output constraint from "=m" (addr) to "+m" (addr).

@nysal
Copy link
Member Author

nysal commented Jan 12, 2017

@hjelmn I didn't change it to "+m" because of issue #2086.

@jsquyres
Copy link
Member

@hppritcha I took the liberty of adding "RM approved" to this one

@hjelmn
Copy link
Member

hjelmn commented Jan 12, 2017

Ah yes. Forgot about the pgi bug. All good then

@jsquyres jsquyres changed the title asm/ppc: Fix a regression in powerpc atomics v2.0.x: asm/ppc: Fix a regression in powerpc atomics Jan 12, 2017
@jsquyres
Copy link
Member

@hjelmn Can you formally review this PR? (and #2707)

@jsquyres
Copy link
Member

@hjelmn Thanks
@hppritcha I think this is good to go.

@hppritcha hppritcha merged commit b37a50d into open-mpi:v2.0.x Jan 12, 2017
@nysal nysal deleted the ppc_atomic_v2.0.x branch February 26, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants