MPI.h: restore some removed deprecated items #6013
Conversation
|
This PR replaces #6008 which went off into the weeds. |
ompi/include/mpi.h.in
Outdated
| /* | ||
| * Removed typedefs. These will be deleted in a future Open MPI release. | ||
| * Deprecated typedefs. These will be deleted in a future MPI standard. |
There was a problem hiding this comment.
I said this on the last PR: "deprecated" != "will be deleted in a future MPI standard".
There was a problem hiding this comment.
Dang it, I missed this, thanks.
Any idea why the build Checker failed? Something about --no-orte and --no-oshmem failures, but that's all I can understand.
There was a problem hiding this comment.
Looks like a local AWS failure. Just do a retest.
There was a problem hiding this comment.
Hmm, so that's an AWS filesystem failure? I hope so, since I'm not sure how it generates that orte/constants.h (which is what it couldn't find).
There was a problem hiding this comment.
Hmm when I looked at the logs for those 2 builds (admittedly somewhat quickly), I thought they said they had problems clearing out the working directory to do the next build. I took that to mean it was a local AWS error. Perhaps I read them wrong / too quickly...?
Regardless, you just pushed to the PR again -- we'll see how AWS CI does this time...
|
bot:ompi:retest |
gpaulsen
force-pushed
the
task/restore_removed_mpi_items
branch
from
c2bf852 to
cf3c3e5
Compare
gpaulsen
dismissed
jsquyres’s stale review
changed deprecated from "will be removed in the future" to a cut-n-paste from the standard of "may be removed in a future version of the standard".
Commit 89da965 inadvertantly #if'ed out both deprecated *and* removed items from mpi.h. The intent was only to #if out items that have been *removed* from the MPI specification and leave all items that are merely deprecated. This commit also re-orders the deleted typedef+functions to be in the same order as they are listed in MPI-3.1 chapter 17, just to make verifying/checking the code easier. Note that --enable-mpi1-compatibility can still be used to restore prototypes for the items that have been removed from the MPI specification (e.g., MPI_Address()). Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com> Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
task/restore_removed_mpi_items
branch
from
cf3c3e5 to
b03a39d
Compare
|
Unfortunately, this only restored the prototypes for the deprecated functions. But these are still only available, if configured with Actually, I though there are no functions removed at all, only the prototypes. Thus I don't understand why the makefiles have this condition at all. |
In commit 89da965, we finally removed some MPI items that were
removed in MPI 3.0 / 3.1 (Unless the user configures with an
mpi1-compat flag). Unfortunately some of the items removed in
that commit, were NOT removed in the standard, and should have
remained merely deprecated.
This commit brings those items back, as deprecated both
with and without the --mpi1-compat flag (which only affects
removed items)
Signed-off-by: Geoffrey Paulsen gpaulsen@us.ibm.com