Skip to content

Ensure we get our local topology #7547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Ensure we get our local topology #7547

merged 1 commit into from
Mar 23, 2020

Conversation

rhc54
Copy link
Contributor

@rhc54 rhc54 commented Mar 20, 2020

Restore missing call to get_topology - others were doing it in their
components as repeated calls just return success, but let's ensure it is
always present.

Signed-off-by: Ralph Castain rhc@pmix.org

Restore missing call to get_topology - others were doing it in their
components as repeated calls just return success, but let's ensure it is
always present.

Signed-off-by: Ralph Castain <rhc@pmix.org>
@rhc54 rhc54 requested a review from bwbarrett March 20, 2020 16:29
@rhc54 rhc54 self-assigned this Mar 20, 2020
@awlauria awlauria merged commit cf5ca14 into open-mpi:master Mar 23, 2020
@rhc54
Copy link
Contributor Author

rhc54 commented Mar 23, 2020

Urrrr....I believe the discussion on the devel mailing list had concluded that we didn't want to commit this one. The mtl/ofi component was going to call opal_hwloc_get_topology to ensure the topology was present just as all the other components who need the topo do, thus preserving the "only load the topology if someone will actually use it" philosophy.

@awlauria
Copy link
Contributor

awlauria commented Mar 23, 2020

@rhc54 ah - I must have missed that email...My bad. I can revert this.

@awlauria
Copy link
Contributor

#7558

@rhc54 ^

@rhc54 rhc54 deleted the topic/hwloc branch April 1, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants