Skip to content

README: Fix the missing parentheses #7605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

README: Fix the missing parentheses #7605

merged 1 commit into from
Apr 7, 2020

Conversation

Evstrife
Copy link
Contributor

@Evstrife Evstrife commented Apr 6, 2020

Signed-off-by: Evstrife wus217@wfu.edu

Fix the missing parentheses on line 412

#daemondeacons

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@awlauria
Copy link
Contributor

awlauria commented Apr 6, 2020

ok to test

@awlauria
Copy link
Contributor

awlauria commented Apr 6, 2020

@Evstrife can you please fix your commit message?

Thanks!

@Evstrife Evstrife changed the title Fix the missing parentheses on line 412 README: Fix the missing parentheses Apr 6, 2020
@jsquyres
Copy link
Member

jsquyres commented Apr 6, 2020

@Evstrife can you please fix your commit message?

Specifically, your commit message appears to be a bit jumbled:

j
    
Signed-off-by: Evstrife <wus217@wfu.edu>
    
Fix the missing parentheses on line 412
    
Signed-off-by: Siyu Wu wus217@wfu.edu

Can you have a good title line+content, followed by a single signed off line?

Thanks!

@awlauria
Copy link
Contributor

awlauria commented Apr 6, 2020

@Evstrife you'll need to to do a git commit --amend and force push to change the message.

@Evstrife
Copy link
Contributor Author

Evstrife commented Apr 6, 2020

@Evstrife you'll need to to do a git commit --amend and force push to change the message.

Thanks, I've changed the commit message.

awlauria
awlauria suggested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@awlauria awlauria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like a change on line 407 snuck in. Can you fix that?

@Evstrife
Copy link
Contributor Author

Evstrife commented Apr 6, 2020

Actually, looks like a change on line 407 snuck in. Can you fix that?

I changed it to 407 now. thx

jsquyres
jsquyres reviewed Apr 6, 2020
View reviewed changes
@Evstrife Evstrife force-pushed the pr/fix-README2 branch 4 times, most recently from 0545d70 to 2614840 Compare April 6, 2020 23:44
@Evstrife
README: Fix the missing parentheses in line 407
6da4ad2 
change

	provided depending on your Fortran compiler):

 to
	provided (depending on your Fortran compiler):

Signed-off-by: Evstrife <wus217@wfu.edu>
@awlauria awlauria merged commit e90d44a into open-mpi:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquyres jsquyres jsquyres left review comments

@awlauria awlauria awlauria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Evstrife @ompiteam-bot @awlauria @jsquyres